From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcNUr-0005HH-E4 for qemu-devel@nongnu.org; Sun, 18 Dec 2011 15:38:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RcNUq-0006zE-GH for qemu-devel@nongnu.org; Sun, 18 Dec 2011 15:38:13 -0500 Received: from mnementh.archaic.org.uk ([81.2.115.146]:38904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcNUq-0006yK-4V for qemu-devel@nongnu.org; Sun, 18 Dec 2011 15:38:12 -0500 From: Peter Maydell Date: Sun, 18 Dec 2011 20:37:57 +0000 Message-Id: <1324240680-26905-8-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1324240680-26905-1-git-send-email-peter.maydell@linaro.org> References: <1324240680-26905-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 07/10] hw/sd.c: Set ILLEGAL_COMMAND for ACMDs in invalid state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: patches@linaro.org App commands in an invalid state should set ILLEGAL_COMMAND, not merely return a zero response. Signed-off-by: Peter Maydell --- hw/sd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/sd.c b/hw/sd.c index 9116f67..9eebfac 100644 --- a/hw/sd.c +++ b/hw/sd.c @@ -1262,7 +1262,7 @@ static sd_rsp_type_t sd_app_command(SDState *sd, } fprintf(stderr, "SD: ACMD%i in a wrong state\n", req.cmd); - return sd_r0; + return sd_illegal; } static int cmd_valid_while_locked(SDState *sd, SDRequest *req) -- 1.7.5.4