From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Michael Ellerman <michael@ellerman.id.au>,
Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 04/17] kvm: Print something before calling abort() if KVM_RUN fails
Date: Mon, 19 Dec 2011 11:12:25 +0000 [thread overview]
Message-ID: <1324293158-25433-5-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1324293158-25433-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: Michael Ellerman <michael@ellerman.id.au>
It's a little unfriendly to call abort() without printing any sort of
error message. So turn the DPRINTK() into an fprintf(stderr, ...).
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
kvm-all.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 4c466d6..ac048bc 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -977,7 +977,8 @@ int kvm_cpu_exec(CPUState *env)
ret = EXCP_INTERRUPT;
break;
}
- DPRINTF("kvm run failed %s\n", strerror(-run_ret));
+ fprintf(stderr, "error: kvm run failed %s\n",
+ strerror(-run_ret));
abort();
}
--
1.7.7.3
next prev parent reply other threads:[~2011-12-19 11:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 11:12 [Qemu-devel] [PULL 00/17] Trivial patches for 7 to 19 December 2011 Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 01/17] ide: drop argument to dma_buf_commit Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 02/17] Makefile.target: Remove unnecessary dependency rules Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 03/17] stellaris: Calculate system clock period on reset Stefan Hajnoczi
2011-12-19 11:12 ` Stefan Hajnoczi [this message]
2011-12-19 11:12 ` [Qemu-devel] [PATCH 05/17] slirp: Fix typo in net_slirp_hostfwd_remove Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 06/17] Also create piix3 property when Xen is enabled Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 07/17] configure: Fix compiler warnings in config.log (always return a value from main) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 08/17] configure: Fix compiler warnings in config.log (old-style function definition) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 09/17] configure: Fix compiler warning in config.log (integer from pointer) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 10/17] configure: Fix compiler warnings in config.log (null arguments) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 11/17] configure: Fix compiler warning in config.log (unused variable) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 12/17] configure: Fix compiler warning in config.log (macro redefined) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 13/17] configure: Fix compiler warnings in config.log (uninitialized variable) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 14/17] configure: Fix compiler warning in config.log (undefined NULL) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 15/17] configure: Fix compiler warning in config.log (value was never used) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 16/17] configure: Fix compiler warnings in config.log (statement without effect) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 17/17] configure: Improve Xen autodetection for hosts without Xen Stefan Hajnoczi
2011-12-19 15:44 ` [Qemu-devel] [PULL 00/17] Trivial patches for 7 to 19 December 2011 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324293158-25433-5-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=michael@ellerman.id.au \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).