qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Julian Pidancet <julian.pidancet@gmail.com>
Subject: [Qemu-devel] [PATCH 06/17] Also create piix3 property when Xen is enabled
Date: Mon, 19 Dec 2011 11:12:27 +0000	[thread overview]
Message-ID: <1324293158-25433-7-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1324293158-25433-1-git-send-email-stefanha@linux.vnet.ibm.com>

From: Julian Pidancet <julian.pidancet@gmail.com>

This recently added line in hw/pc_piix.c is causing a SEGV on a Xen
setup because the piix3 property is never created:

qdev_property_add_child(qdev_resolve_path("/i440fx/piix3", NULL),
                            "rtc", (DeviceState *)rtc_state, NULL);

Signed-off-by: Julian Pidancet <julian.pidancet@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 hw/piix_pci.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index d785d4b..ea156a9 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -324,9 +324,8 @@ static PCIBus *i440fx_common_init(const char *device_name,
                 pci_create_simple_multifunction(b, -1, true, "PIIX3"));
         pci_bus_irqs(b, piix3_set_irq, pci_slot_get_pirq, piix3,
                 PIIX_NUM_PIRQS);
-
-        qdev_property_add_child(dev, "piix3", &piix3->dev.qdev, NULL);
     }
+    qdev_property_add_child(dev, "piix3", &piix3->dev.qdev, NULL);
     piix3->pic = pic;
 
     (*pi440fx_state)->piix3 = piix3;
-- 
1.7.7.3

  parent reply	other threads:[~2011-12-19 11:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-19 11:12 [Qemu-devel] [PULL 00/17] Trivial patches for 7 to 19 December 2011 Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 01/17] ide: drop argument to dma_buf_commit Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 02/17] Makefile.target: Remove unnecessary dependency rules Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 03/17] stellaris: Calculate system clock period on reset Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 04/17] kvm: Print something before calling abort() if KVM_RUN fails Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 05/17] slirp: Fix typo in net_slirp_hostfwd_remove Stefan Hajnoczi
2011-12-19 11:12 ` Stefan Hajnoczi [this message]
2011-12-19 11:12 ` [Qemu-devel] [PATCH 07/17] configure: Fix compiler warnings in config.log (always return a value from main) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 08/17] configure: Fix compiler warnings in config.log (old-style function definition) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 09/17] configure: Fix compiler warning in config.log (integer from pointer) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 10/17] configure: Fix compiler warnings in config.log (null arguments) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 11/17] configure: Fix compiler warning in config.log (unused variable) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 12/17] configure: Fix compiler warning in config.log (macro redefined) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 13/17] configure: Fix compiler warnings in config.log (uninitialized variable) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 14/17] configure: Fix compiler warning in config.log (undefined NULL) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 15/17] configure: Fix compiler warning in config.log (value was never used) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 16/17] configure: Fix compiler warnings in config.log (statement without effect) Stefan Hajnoczi
2011-12-19 11:12 ` [Qemu-devel] [PATCH 17/17] configure: Improve Xen autodetection for hosts without Xen Stefan Hajnoczi
2011-12-19 15:44 ` [Qemu-devel] [PULL 00/17] Trivial patches for 7 to 19 December 2011 Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324293158-25433-7-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=julian.pidancet@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).