From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
"Benoît Canet" <benoit.canet@gmail.com>,
"Avi Kivity" <avi@redhat.com>,
patches@linaro.org
Subject: [Qemu-devel] [PATCH v2 1/2] hw/integratorcp: Fix sense of REMAP bit
Date: Tue, 20 Dec 2011 16:08:55 +0000 [thread overview]
Message-ID: <1324397336-31206-2-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1324397336-31206-1-git-send-email-peter.maydell@linaro.org>
Fix the sense of the REMAP bit: 0 should mean "map flash",
1 should mean "map RAM".
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/integratorcp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/integratorcp.c b/hw/integratorcp.c
index 2551236..8e4c154 100644
--- a/hw/integratorcp.c
+++ b/hw/integratorcp.c
@@ -112,7 +112,7 @@ static uint64_t integratorcm_read(void *opaque, target_phys_addr_t offset,
static void integratorcm_do_remap(integratorcm_state *s, int flash)
{
- if (flash) {
+ if (!flash) {
if (s->flash_mapped) {
sysbus_del_memory(&s->busdev, &s->flash);
s->flash_mapped = false;
--
1.7.5.4
next prev parent reply other threads:[~2011-12-20 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 16:08 [Qemu-devel] [PATCH v2 0/2] integratorcp: fix and simplify flash remap code Peter Maydell
2011-12-20 16:08 ` Peter Maydell [this message]
2011-12-20 16:08 ` [Qemu-devel] [PATCH v2 2/2] hw/integratorcp: Simplify " Peter Maydell
2011-12-20 16:37 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324397336-31206-2-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=benoit.canet@gmail.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).