From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rd2w1-0007oG-Da for qemu-devel@nongnu.org; Tue, 20 Dec 2011 11:53:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rd2vu-0006aM-WE for qemu-devel@nongnu.org; Tue, 20 Dec 2011 11:53:01 -0500 Received: from cpe-70-123-132-139.austin.res.rr.com ([70.123.132.139]:41705 helo=localhost6.localdomain6) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rd2vu-0006aD-PY for qemu-devel@nongnu.org; Tue, 20 Dec 2011 11:52:54 -0500 From: Anthony Liguori Date: Tue, 20 Dec 2011 10:51:51 -0600 Message-Id: <1324399916-21315-23-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1324399916-21315-1-git-send-email-aliguori@us.ibm.com> References: <1324399916-21315-1-git-send-email-aliguori@us.ibm.com> Subject: [Qemu-devel] [PATCH 22/27] not-for-upstream: virtio-serial: stub out a strange hack List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Amit Shah , Paolo Bonzini , Anthony Liguori , Markus Armbruster You shouldn't override class methods in an object initialization function. Whatever the code is trying to achieve here, it needs to be rethought and done in a better way. Amit, if you can give me some insight into what's going on here, I can take a look at refactoring. Cc: Amit Shah --- hw/virtio-console.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index f922400..6c32e7f 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -109,9 +109,13 @@ static int virtconsole_initfn(VirtIOSerialPort *port) if (vcon->chr) { qemu_chr_add_handlers(vcon->chr, chr_can_read, chr_read, chr_event, vcon); - info->have_data = flush_buf; - info->guest_open = guest_open; - info->guest_close = guest_close; + /* FIXME: This is not right */ + abort(); + if (0) { + info->have_data = flush_buf; + info->guest_open = guest_open; + info->guest_close = guest_close; + } } return 0; -- 1.7.4.1