From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Juha Riihimäki" <juha.riihimaki@nokia.com>,
"Riku Voipio" <riku.voipio@iki.fi>,
patches@linaro.org
Subject: [Qemu-devel] [PATCH 1/6] hw/omap1.c: omap_mpuio_init() need not be public
Date: Tue, 20 Dec 2011 18:11:31 +0000 [thread overview]
Message-ID: <1324404696-31368-2-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1324404696-31368-1-git-send-email-peter.maydell@linaro.org>
omap_mpuio_init() is only used and defined in omap1.c, so make it static.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/omap.h | 4 ----
hw/omap1.c | 2 +-
2 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/hw/omap.h b/hw/omap.h
index 42eb361..5fe33db 100644
--- a/hw/omap.h
+++ b/hw/omap.h
@@ -672,10 +672,6 @@ void omap_uart_reset(struct omap_uart_s *s);
void omap_uart_attach(struct omap_uart_s *s, CharDriverState *chr);
struct omap_mpuio_s;
-struct omap_mpuio_s *omap_mpuio_init(MemoryRegion *system_memory,
- target_phys_addr_t base,
- qemu_irq kbd_int, qemu_irq gpio_int, qemu_irq wakeup,
- omap_clk clk);
qemu_irq *omap_mpuio_in_get(struct omap_mpuio_s *s);
void omap_mpuio_out_set(struct omap_mpuio_s *s, int line, qemu_irq handler);
void omap_mpuio_key(struct omap_mpuio_s *s, int row, int col, int down);
diff --git a/hw/omap1.c b/hw/omap1.c
index 53cde76..dddac92 100644
--- a/hw/omap1.c
+++ b/hw/omap1.c
@@ -2066,7 +2066,7 @@ static void omap_mpuio_onoff(void *opaque, int line, int on)
omap_mpuio_kbd_update(s);
}
-struct omap_mpuio_s *omap_mpuio_init(MemoryRegion *memory,
+static struct omap_mpuio_s *omap_mpuio_init(MemoryRegion *memory,
target_phys_addr_t base,
qemu_irq kbd_int, qemu_irq gpio_int, qemu_irq wakeup,
omap_clk clk)
--
1.7.1
next prev parent reply other threads:[~2011-12-20 18:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 18:11 [Qemu-devel] [PATCH 0/6] omap1: Separate omap1 subdevices from omap_mpu_state Peter Maydell
2011-12-20 18:11 ` Peter Maydell [this message]
2011-12-20 18:11 ` [Qemu-devel] [PATCH 2/6] hw/omap1.c: Separate PWL " Peter Maydell
2011-12-20 18:11 ` [Qemu-devel] [PATCH 3/6] hw/omap1.c: Separate PWT " Peter Maydell
2011-12-20 18:11 ` [Qemu-devel] [PATCH 4/6] hw/omap1.c: Separate dpll_ctl " Peter Maydell
2011-12-20 18:11 ` [Qemu-devel] [PATCH 5/6] hw/omap1.c: Separate clkm " Peter Maydell
2011-12-21 1:38 ` andrzej zaborowski
2011-12-21 11:07 ` Peter Maydell
2012-01-04 10:37 ` Peter Maydell
2011-12-20 18:11 ` [Qemu-devel] [PATCH 6/6] hw/omap1.c: Drop unused includes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324404696-31368-2-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=juha.riihimaki@nokia.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).