qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 01/26] add qemu_send_full and qemu_recv_full
Date: Fri, 23 Dec 2011 16:26:05 +0100	[thread overview]
Message-ID: <1324653990-20074-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1324653990-20074-1-git-send-email-pbonzini@redhat.com>

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 osdep.c       |   67 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 qemu-common.h |    4 +++
 2 files changed, 71 insertions(+), 0 deletions(-)

diff --git a/osdep.c b/osdep.c
index 56e6963..70bad27 100644
--- a/osdep.c
+++ b/osdep.c
@@ -166,3 +166,70 @@ int qemu_accept(int s, struct sockaddr *addr, socklen_t *addrlen)
 
     return ret;
 }
+
+/*
+ * A variant of send(2) which handles partial write.
+ *
+ * Return the number of bytes transferred, which is only
+ * smaller than `count' if there is an error.
+ *
+ * This function won't work with non-blocking fd's.
+ * Any of the possibilities with non-bloking fd's is bad:
+ *   - return a short write (then name is wrong)
+ *   - busy wait adding (errno == EAGAIN) to the loop
+ */
+ssize_t qemu_send_full(int fd, const void *buf, size_t count, int flags)
+{
+    ssize_t ret = 0;
+    ssize_t total = 0;
+
+    while (count) {
+        ret = send(fd, buf, count, flags);
+        if (ret < 0) {
+            if (errno == EINTR) {
+                continue;
+            }
+            break;
+        }
+
+        count -= ret;
+        buf += ret;
+        total += ret;
+    }
+
+    return total;
+}
+
+/*
+ * A variant of recv(2) which handles partial write.
+ *
+ * Return the number of bytes transferred, which is only
+ * smaller than `count' if there is an error.
+ *
+ * This function won't work with non-blocking fd's.
+ * Any of the possibilities with non-bloking fd's is bad:
+ *   - return a short write (then name is wrong)
+ *   - busy wait adding (errno == EAGAIN) to the loop
+ */
+ssize_t qemu_recv_full(int fd, void *buf, size_t count, int flags)
+{
+    ssize_t ret = 0;
+    ssize_t total = 0;
+
+    while (count) {
+        ret = qemu_recv(fd, buf, count, flags);
+        if (ret <= 0) {
+            if (ret < 0 && errno == EINTR) {
+                continue;
+            }
+            break;
+        }
+
+        count -= ret;
+        buf += ret;
+        total += ret;
+    }
+
+    return total;
+}
+
diff --git a/qemu-common.h b/qemu-common.h
index b2de015..5c3f3af 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -173,6 +173,10 @@ void *qemu_oom_check(void *ptr);
 int qemu_open(const char *name, int flags, ...);
 ssize_t qemu_write_full(int fd, const void *buf, size_t count)
     QEMU_WARN_UNUSED_RESULT;
+ssize_t qemu_send_full(int fd, const void *buf, size_t count, int flags)
+    QEMU_WARN_UNUSED_RESULT;
+ssize_t qemu_recv_full(int fd, const void *buf, size_t count, int flags)
+    QEMU_WARN_UNUSED_RESULT;
 void qemu_set_cloexec(int fd);
 
 #ifndef _WIN32
-- 
1.7.7.1

  reply	other threads:[~2011-12-23 15:27 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-23 15:26 [Qemu-devel] [PULL 00/26] nbd refactoring, fully asynchronous operation, flushing, fixes Paolo Bonzini
2011-12-23 15:26 ` Paolo Bonzini [this message]
2011-12-23 15:26 ` [Qemu-devel] [PATCH 02/26] sheepdog: move coroutine send/recv function to generic code Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 03/26] nbd: switch to asynchronous operation Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 04/26] nbd: split requests Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 05/26] nbd: allow multiple in-flight requests Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 06/26] nbd: fix error handling in the server Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 07/26] nbd: add support for NBD_CMD_FLAG_FUA Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 08/26] nbd: add support for NBD_CMD_FLUSH Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 09/26] nbd: add support for NBD_CMD_TRIM Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 10/26] Update ioctl order in nbd_init() to detect EBUSY Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 11/26] qemu-nbd: remove offset argument to nbd_trip Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 12/26] qemu-nbd: remove data_size " Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 13/26] move corking functions to osdep.c Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 14/26] qemu-nbd: simplify nbd_trip Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 15/26] qemu-nbd: introduce nbd_do_send_reply Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 16/26] qemu-nbd: more robust handling of invalid requests Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 17/26] qemu-nbd: introduce nbd_do_receive_request Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 18/26] qemu-nbd: introduce NBDExport Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 19/26] qemu-nbd: introduce NBDRequest Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 20/26] link the main loop and its dependencies into the tools Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 21/26] qemu-nbd: use common main loop Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 22/26] qemu-nbd: move client handling to nbd.c Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 23/26] qemu-nbd: add client pointer to NBDRequest Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 24/26] qemu-nbd: asynchronous operation Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 25/26] qemu-nbd: throttle requests Paolo Bonzini
2011-12-23 15:26 ` [Qemu-devel] [PATCH 26/26] nbd: add myself as maintainer Paolo Bonzini
2011-12-27 16:36 ` [Qemu-devel] [PULL 00/26] nbd refactoring, fully asynchronous operation, flushing, fixes Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324653990-20074-2-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).