From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: [Qemu-devel] [PATCH 0/2] ARM: fix crash/abort when setting invalid mode
Date: Sat, 24 Dec 2011 18:59:05 +0000 [thread overview]
Message-ID: <1324753147-5747-1-git-send-email-peter.maydell@linaro.org> (raw)
https://bugs.launchpad.net/qemu/+bug/607794 reports a problem
where qemu will segfault if you try to set CPSR to an invalid
mode via the gdb stub. These patches fix the segfault by not
using cpu_single_env when it might not be valid, and also avoid
the problem by not aborting in this situation. Instead we simply
ignore attempts to set the mode field to an invalid value.
(This case is UNPREDICTABLE so this is a legitimate choice, and
behaviour that can be provoked by guests or confused users at
the debugger shouldn't cause us to abort.)
Peter Maydell (2):
target-arm: Don't use cpu_single_env in bank_number()
target-arm: Ignore attempts to set invalid modes in CPSR
target-arm/helper.c | 42 +++++++++++++++++++++++++++++++++++-------
1 files changed, 35 insertions(+), 7 deletions(-)
--
1.7.5.4
next reply other threads:[~2011-12-24 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-24 18:59 Peter Maydell [this message]
2011-12-24 18:59 ` [Qemu-devel] [PATCH 1/2] target-arm: Don't use cpu_single_env in bank_number() Peter Maydell
2011-12-24 18:59 ` [Qemu-devel] [PATCH 2/2] target-arm: Ignore attempts to set invalid modes in CPSR Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324753147-5747-1-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).