From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Reb9c-0006VI-0t for qemu-devel@nongnu.org; Sat, 24 Dec 2011 18:37:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Reb9b-0008Jg-4y for qemu-devel@nongnu.org; Sat, 24 Dec 2011 18:37:27 -0500 From: Peter Maydell Date: Sat, 24 Dec 2011 23:37:24 +0000 Message-Id: <1324769844-5991-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] gdbstub: Fix fd leak in gdbserver_open() error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, patches@linaro.org Fix a leak of a file descriptor in error exit paths in gdbserver_open(). Signed-off-by: Peter Maydell --- Of no great consequence, but it was in the pile of coverity complaints and it's a trivial fix. gdbstub.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index a5806ef..7d470b6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2762,11 +2762,13 @@ static int gdbserver_open(int port) ret = bind(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)); if (ret < 0) { perror("bind"); + close(fd); return -1; } ret = listen(fd, 0); if (ret < 0) { perror("listen"); + close(fd); return -1; } return fd; -- 1.7.5.4