* [Qemu-devel] [PATCH] net/socket.c: Fix fd leak in net_socket_listen_init() error paths
@ 2011-12-24 23:47 Peter Maydell
2012-01-03 10:51 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2011-12-24 23:47 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, patches
Fix a leak of a file descriptor due to missing closesocket() calls
in error paths in net_socket_listen_init().
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Coverity again...
net/socket.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index aaf9be4..c9d70d3 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -427,12 +427,14 @@ static int net_socket_listen_init(VLANState *vlan,
if (ret < 0) {
perror("bind");
g_free(s);
+ closesocket(fd);
return -1;
}
ret = listen(fd, 0);
if (ret < 0) {
perror("listen");
g_free(s);
+ closesocket(fd);
return -1;
}
s->vlan = vlan;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] net/socket.c: Fix fd leak in net_socket_listen_init() error paths
2011-12-24 23:47 [Qemu-devel] [PATCH] net/socket.c: Fix fd leak in net_socket_listen_init() error paths Peter Maydell
@ 2012-01-03 10:51 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2012-01-03 10:51 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
On Sat, Dec 24, 2011 at 11:47:11PM +0000, Peter Maydell wrote:
> Fix a leak of a file descriptor due to missing closesocket() calls
> in error paths in net_socket_listen_init().
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Coverity again...
>
> net/socket.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
Thanks, applied to the trivial patches -next tree:
https://github.com/stefanha/qemu/commits/trivial-patches-next
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-03 10:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-24 23:47 [Qemu-devel] [PATCH] net/socket.c: Fix fd leak in net_socket_listen_init() error paths Peter Maydell
2012-01-03 10:51 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).