From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RebJ4-0007kW-FB for qemu-devel@nongnu.org; Sat, 24 Dec 2011 18:47:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RebJ3-0000zs-Ka for qemu-devel@nongnu.org; Sat, 24 Dec 2011 18:47:14 -0500 From: Peter Maydell Date: Sat, 24 Dec 2011 23:47:11 +0000 Message-Id: <1324770431-6074-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] net/socket.c: Fix fd leak in net_socket_listen_init() error paths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, patches@linaro.org Fix a leak of a file descriptor due to missing closesocket() calls in error paths in net_socket_listen_init(). Signed-off-by: Peter Maydell --- Coverity again... net/socket.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/socket.c b/net/socket.c index aaf9be4..c9d70d3 100644 --- a/net/socket.c +++ b/net/socket.c @@ -427,12 +427,14 @@ static int net_socket_listen_init(VLANState *vlan, if (ret < 0) { perror("bind"); g_free(s); + closesocket(fd); return -1; } ret = listen(fd, 0); if (ret < 0) { perror("listen"); g_free(s); + closesocket(fd); return -1; } s->vlan = vlan; -- 1.7.5.4