From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
"Ehsan Ul Haq" <ehsan.ulhaq@kics.edu.pk>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH 05/11] linux-user: Fix sa_flags byte swaps for mips
Date: Thu, 29 Dec 2011 16:55:43 +0100 [thread overview]
Message-ID: <1325174149-8077-6-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1325174149-8077-1-git-send-email-afaerber@suse.de>
sa_flags is uint32_t for mips{,n32,64}, so don't use tswapal().
Reported-by: Khansa Butt <khansa@kics.edu.pk>
Suggested-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Cc: Ehsan Ul Haq <ehsan.ulhaq@kics.edu.pk>
---
linux-user/signal.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index ded12ca..bafbc57 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -587,7 +587,11 @@ int do_sigaction(int sig, const struct target_sigaction *act,
#endif
if (oact) {
oact->_sa_handler = tswapal(k->_sa_handler);
+#if defined(TARGET_MIPS)
+ oact->sa_flags = bswap32(k->sa_flags);
+#else
oact->sa_flags = tswapal(k->sa_flags);
+#endif
#if !defined(TARGET_MIPS)
oact->sa_restorer = tswapal(k->sa_restorer);
#endif
@@ -596,7 +600,11 @@ int do_sigaction(int sig, const struct target_sigaction *act,
if (act) {
/* FIXME: This is not threadsafe. */
k->_sa_handler = tswapal(act->_sa_handler);
+#if defined(TARGET_MIPS)
+ k->sa_flags = bswap32(act->sa_flags);
+#else
k->sa_flags = tswapal(act->sa_flags);
+#endif
#if !defined(TARGET_MIPS)
k->sa_restorer = tswapal(act->sa_restorer);
#endif
--
1.7.7
next prev parent reply other threads:[~2011-12-29 15:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 15:55 [Qemu-devel] [RFC 00/11] linux-user: Sort out signal handling for MIPS n32 and n64 Andreas Färber
2011-12-29 15:55 ` [Qemu-devel] [PATCH 01/11] linux-user: Add default-configs for mipsn32[el] Andreas Färber
2011-12-29 15:55 ` [Qemu-devel] [PATCH 02/11] linux-user: Add default configs for mips64[el] Andreas Färber
2011-12-29 15:55 ` [Qemu-devel] [PATCH 03/11] linux-user: Define TARGET_QEMU_ESIGRETURN for mipsn32 Andreas Färber
2011-12-29 15:55 ` [Qemu-devel] [PATCH 04/11] linux-user: Define TARGET_QEMU_ESIGRETURN for mips64 Andreas Färber
2011-12-29 15:55 ` Andreas Färber [this message]
2011-12-29 15:55 ` [Qemu-devel] [RFC 06/11] linux-user: Unify signal handling for mips Andreas Färber
2011-12-29 15:55 ` [Qemu-devel] [RFC 07/11] linux-user: target_sigcontext for mipsn32 and mips64 Andreas Färber
2011-12-29 15:55 ` [Qemu-devel] [RFC 08/11] linux-user: Share {setup, restore}_sigcontext() for mips ABIs Andreas Färber
2011-12-29 15:55 ` [Qemu-devel] [RFC 09/11] linux-user: Setup/restore sc_acx for mips and mipsn32 Andreas Färber
2011-12-29 15:55 ` [Qemu-devel] [PATCH 10/11] linux-user: mipsn32 does not support non-RT signals Andreas Färber
2011-12-29 15:55 ` [Qemu-devel] [RFC 11/11] linux-user: Implement signal handling for mipsn32 Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325174149-8077-6-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=ehsan.ulhaq@kics.edu.pk \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).