From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiACD-0008Br-Ac for qemu-devel@nongnu.org; Tue, 03 Jan 2012 14:38:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RiACB-00075M-Lc for qemu-devel@nongnu.org; Tue, 03 Jan 2012 14:38:52 -0500 Received: from mail-ee0-f45.google.com ([74.125.83.45]:57089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiACB-000724-Gz for qemu-devel@nongnu.org; Tue, 03 Jan 2012 14:38:51 -0500 Received: by mail-ee0-f45.google.com with SMTP id b45so18975974eek.4 for ; Tue, 03 Jan 2012 11:38:51 -0800 (PST) Sender: Fabio Erculiani From: Fabio Erculiani Date: Tue, 3 Jan 2012 20:38:35 +0100 Message-Id: <1325619515-1729-2-git-send-email-lxnay@sabayon.org> In-Reply-To: <1325619515-1729-1-git-send-email-lxnay@sabayon.org> References: <1325619515-1729-1-git-send-email-lxnay@sabayon.org> Subject: [Qemu-devel] [PATCH v3 2/2] linux-user: target_argv is placed on ts->bprm->argv and can't be freed() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Fabio Erculiani , riku.voipio@iki.fi, agraf@suse.de TaskState contains linux_bprm struct which encapsulates argv among other things. argv might be used around the code and is expected to contain valid data. Before this patch, ts->bprm->argv was NULL due to it being freed right after loader_exec(). Signed-off-by: Fabio Erculiani --- linux-user/main.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 788ff98..513d583 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -3492,11 +3492,6 @@ int main(int argc, char **argv, char **envp) _exit(1); } - for (i = 0; i < target_argc; i++) { - free(target_argv[i]); - } - free(target_argv); - for (wrk = target_environ; *wrk; wrk++) { free(*wrk); } -- 1.7.7