From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiG7t-0006QF-P6 for qemu-devel@nongnu.org; Tue, 03 Jan 2012 20:58:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RiG7q-0004KT-Rf for qemu-devel@nongnu.org; Tue, 03 Jan 2012 20:58:49 -0500 Received: from cantor2.suse.de ([195.135.220.15]:46330 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiG7q-0004Jr-HV for qemu-devel@nongnu.org; Tue, 03 Jan 2012 20:58:46 -0500 From: Alexander Graf Date: Wed, 4 Jan 2012 03:13:07 +0100 Message-Id: <1325643192-15941-2-git-send-email-agraf@suse.de> In-Reply-To: <1325643192-15941-1-git-send-email-agraf@suse.de> References: <1325643192-15941-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH 1/6] [S390] Add hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org Developers" Cc: Blue Swirl , Aurelien Jarno I just submitted a few patches that enable the s390 virtio bus to receive a hotplug add event. This patch implements the qemu side of it, so that new hotplug events can be submitted to the guest. Signed-off-by: Alexander Graf --- v1 -> v2: - make s390 virtio hoplug code emulate-capable --- hw/s390-virtio-bus.c | 24 +++++++++++++++++++----- hw/s390-virtio-bus.h | 5 +++++ 2 files changed, 24 insertions(+), 5 deletions(-) diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c index c4b9a99..2efea9f 100644 --- a/hw/s390-virtio-bus.c +++ b/hw/s390-virtio-bus.c @@ -82,12 +82,24 @@ VirtIOS390Bus *s390_virtio_bus_init(ram_addr_t *ram_size) bus->dev_offs = bus->dev_page; bus->next_ring = bus->dev_page + TARGET_PAGE_SIZE; + /* Enable hotplugging */ + _bus->allow_hotplug = 1; + /* Allocate RAM for VirtIO device pages (descriptors, queues, rings) */ *ram_size += S390_DEVICE_PAGES * TARGET_PAGE_SIZE; return bus; } +static void s390_virtio_irq(CPUState *env, int config_change, uint64_t token) +{ + if (kvm_enabled()) { + kvm_s390_virtio_irq(env, config_change, token); + } else { + cpu_inject_ext(env, VIRTIO_EXT_CODE, config_change, token); + } +} + static int s390_virtio_device_init(VirtIOS390Device *dev, VirtIODevice *vdev) { VirtIOS390Bus *bus; @@ -109,6 +121,11 @@ static int s390_virtio_device_init(VirtIOS390Device *dev, VirtIODevice *vdev) dev->host_features = vdev->get_features(vdev, dev->host_features); s390_virtio_device_sync(dev); + if (dev->qdev.hotplugged) { + CPUState *env = s390_cpu_addr2state(0); + s390_virtio_irq(env, VIRTIO_PARAM_DEV_ADD, dev->dev_offs); + } + return 0; } @@ -310,11 +327,7 @@ static void virtio_s390_notify(void *opaque, uint16_t vector) uint64_t token = s390_virtio_device_vq_token(dev, vector); CPUState *env = s390_cpu_addr2state(0); - if (kvm_enabled()) { - kvm_s390_virtio_irq(env, 0, token); - } else { - cpu_inject_ext(env, VIRTIO_EXT_CODE, 0, token); - } + s390_virtio_irq(env, 0, token); } static unsigned virtio_s390_get_features(void *opaque) @@ -382,6 +395,7 @@ static void s390_virtio_bus_register_withprop(VirtIOS390DeviceInfo *info) { info->qdev.init = s390_virtio_busdev_init; info->qdev.bus_info = &s390_virtio_bus_info; + info->qdev.unplug = qdev_simple_unplug_cb; assert(info->qdev.size >= sizeof(VirtIOS390Device)); qdev_register(&info->qdev); diff --git a/hw/s390-virtio-bus.h b/hw/s390-virtio-bus.h index f1bece7..d02a907 100644 --- a/hw/s390-virtio-bus.h +++ b/hw/s390-virtio-bus.h @@ -35,6 +35,11 @@ #define VIRTIO_RING_LEN (TARGET_PAGE_SIZE * 3) #define S390_DEVICE_PAGES 512 +#define VIRTIO_PARAM_MASK 0xff +#define VIRTIO_PARAM_VRING_INTERRUPT 0x0 +#define VIRTIO_PARAM_CONFIG_CHANGED 0x1 +#define VIRTIO_PARAM_DEV_ADD 0x2 + typedef struct VirtIOS390Device { DeviceState qdev; ram_addr_t dev_offs; -- 1.6.0.2