qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, jcody@redhat.com, mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 1/2] qemu-ga: set O_NONBLOCK for serial channels
Date: Wed,  4 Jan 2012 17:45:12 -0200	[thread overview]
Message-ID: <1325706313-21936-2-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1325706313-21936-1-git-send-email-lcapitulino@redhat.com>

This fixes a bug when using -m isa-serial where qemu-ga will
hang on a read()'s when communicating to the host via isa-serial.

Original fix by Michael Roth.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 qemu-ga.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qemu-ga.c b/qemu-ga.c
index 200bb15..98e4dfe 100644
--- a/qemu-ga.c
+++ b/qemu-ga.c
@@ -504,7 +504,7 @@ static void init_guest_agent(GAState *s)
             exit(EXIT_FAILURE);
         }
     } else if (strcmp(s->method, "isa-serial") == 0) {
-        fd = qemu_open(s->path, O_RDWR | O_NOCTTY);
+        fd = qemu_open(s->path, O_RDWR | O_NOCTTY | O_NONBLOCK);
         if (fd == -1) {
             g_critical("error opening channel: %s", strerror(errno));
             exit(EXIT_FAILURE);
-- 
1.7.8.2.321.g4570a.dirty

  reply	other threads:[~2012-01-04 19:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04 19:45 [Qemu-devel] [PATCH v4 0/2]: qemu-ga: Add the guest-suspend command Luiz Capitulino
2012-01-04 19:45 ` Luiz Capitulino [this message]
2012-01-04 19:55   ` [Qemu-devel] [PATCH 1/2] qemu-ga: set O_NONBLOCK for serial channels Michael Roth
2012-01-04 19:45 ` [Qemu-devel] [PATCH 2/2] qemu-ga: Add the guest-suspend command Luiz Capitulino
2012-01-04 20:00   ` Michael Roth
2012-01-04 20:03   ` Eric Blake
2012-01-05 12:29     ` Luiz Capitulino
2012-01-05 12:46   ` Daniel P. Berrange
2012-01-05 12:58     ` Luiz Capitulino
2012-01-05 10:16 ` [Qemu-devel] [PATCH v4 0/2]: " Daniel P. Berrange
2012-01-05 12:37   ` Luiz Capitulino
2012-01-05 12:59     ` Daniel P. Berrange
2012-01-05 14:42       ` Luiz Capitulino
2012-01-05 15:10         ` Michael Roth
2012-01-05 20:25           ` Luiz Capitulino
2012-01-05 21:41             ` Michael Roth
2012-01-06 19:04               ` Luiz Capitulino
2012-01-06 21:03                 ` Michael Roth
2012-01-05 15:04       ` Michael Roth
2012-01-05 15:11         ` Daniel P. Berrange
2012-01-05 15:18           ` Michael Roth
  -- strict thread matches above, loose matches on Subject: below --
2012-01-13 19:15 [Qemu-devel] [PATCH v5 " Luiz Capitulino
2012-01-13 19:15 ` [Qemu-devel] [PATCH 1/2] qemu-ga: set O_NONBLOCK for serial channels Luiz Capitulino
2012-01-16 20:09 [Qemu-devel] [PATCH v6 0/2]: qemu-ga: Add the guest-suspend command Luiz Capitulino
2012-01-16 20:09 ` [Qemu-devel] [PATCH 1/2] qemu-ga: set O_NONBLOCK for serial channels Luiz Capitulino
2012-01-17 13:27 [Qemu-devel] [PATCH v7 0/2]: qemu-ga: Add the guest-suspend command Luiz Capitulino
2012-01-17 13:27 ` [Qemu-devel] [PATCH 1/2] qemu-ga: set O_NONBLOCK for serial channels Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325706313-21936-2-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=jcody@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).