* [Qemu-devel] [PATCH] configure: Modify detection of supported warning options
@ 2012-01-04 21:47 Stefan Weil
2012-01-09 12:13 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2012-01-04 21:47 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefan Weil
Reversing the order of the warning options and -Werror is important
when clang is used instead of gcc. It changes nothing for gcc.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
configure | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index 640e815..93622e7 100755
--- a/configure
+++ b/configure
@@ -1100,7 +1100,7 @@ cat > $TMPC << EOF
int main(void) { return 0; }
EOF
for flag in $gcc_flags; do
- if compile_prog "$flag -Werror" "" ; then
+ if compile_prog "-Werror $flag" "" ; then
QEMU_CFLAGS="$QEMU_CFLAGS $flag"
fi
done
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Modify detection of supported warning options
2012-01-04 21:47 [Qemu-devel] [PATCH] configure: Modify detection of supported warning options Stefan Weil
@ 2012-01-09 12:13 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2012-01-09 12:13 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On Wed, Jan 04, 2012 at 10:47:16PM +0100, Stefan Weil wrote:
> Reversing the order of the warning options and -Werror is important
> when clang is used instead of gcc. It changes nothing for gcc.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> configure | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-09 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-04 21:47 [Qemu-devel] [PATCH] configure: Modify detection of supported warning options Stefan Weil
2012-01-09 12:13 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).