From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RinBF-0005tc-98 for qemu-devel@nongnu.org; Thu, 05 Jan 2012 08:16:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RinB7-0006Ko-98 for qemu-devel@nongnu.org; Thu, 05 Jan 2012 08:16:29 -0500 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:57121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RinB7-0006KE-28 for qemu-devel@nongnu.org; Thu, 05 Jan 2012 08:16:21 -0500 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Jan 2012 13:16:19 -0000 From: Stefan Hajnoczi Date: Thu, 5 Jan 2012 13:16:07 +0000 Message-Id: <1325769367-32267-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH] qemu-nbd: drop loop which can never loop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Paolo Bonzini , Dr David Alan Gilbert , Stefan Hajnoczi For some reason nbd_client_thread() has a do..while loop which can never loop, the condition is bogus because we would take a goto instead. Drop the loop. Reported-by: Dr David Alan Gilbert Signed-off-by: Stefan Hajnoczi --- qemu-nbd.c | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index 155b058..eb61c33 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -202,12 +202,10 @@ static void *nbd_client_thread(void *arg) int ret; pthread_t show_parts_thread; - do { - sock = unix_socket_outgoing(sockpath); - if (sock == -1) { - goto out; - } - } while (sock == -1); + sock = unix_socket_outgoing(sockpath); + if (sock == -1) { + goto out; + } ret = nbd_receive_negotiate(sock, NULL, &nbdflags, &size, &blocksize); -- 1.7.7.3