From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjC6U-00055o-J8 for qemu-devel@nongnu.org; Fri, 06 Jan 2012 10:53:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjC6T-0006Z0-I9 for qemu-devel@nongnu.org; Fri, 06 Jan 2012 10:53:14 -0500 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:54830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjC6T-0006Yn-6D for qemu-devel@nongnu.org; Fri, 06 Jan 2012 10:53:13 -0500 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 6 Jan 2012 15:53:12 -0000 Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q06Fqk4i2465794 for ; Fri, 6 Jan 2012 15:52:46 GMT Received: from d06av12.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q06Fqka9015917 for ; Fri, 6 Jan 2012 08:52:46 -0700 From: Stefan Hajnoczi Date: Fri, 6 Jan 2012 15:51:28 +0000 Message-Id: <1325865088-23897-10-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1325865088-23897-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1325865088-23897-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 9/9] qemu-nbd: drop loop which can never loop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Stefan Hajnoczi For some reason nbd_client_thread() has a do..while loop which can never loop, the condition is bogus because we would take a goto instead. Drop the loop. Reported-by: Dr David Alan Gilbert Reviewed-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- qemu-nbd.c | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index 155b058..eb61c33 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -202,12 +202,10 @@ static void *nbd_client_thread(void *arg) int ret; pthread_t show_parts_thread; - do { - sock = unix_socket_outgoing(sockpath); - if (sock == -1) { - goto out; - } - } while (sock == -1); + sock = unix_socket_outgoing(sockpath); + if (sock == -1) { + goto out; + } ret = nbd_receive_negotiate(sock, NULL, &nbdflags, &size, &blocksize); -- 1.7.7.3