From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjC69-0003k2-1H for qemu-devel@nongnu.org; Fri, 06 Jan 2012 10:52:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjC67-0006XG-NW for qemu-devel@nongnu.org; Fri, 06 Jan 2012 10:52:52 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:45038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjC67-0006Wz-4H for qemu-devel@nongnu.org; Fri, 06 Jan 2012 10:52:51 -0500 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 6 Jan 2012 15:52:50 -0000 Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q06FqjNT2498668 for ; Fri, 6 Jan 2012 15:52:45 GMT Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q06FqagL026942 for ; Fri, 6 Jan 2012 08:52:37 -0700 From: Stefan Hajnoczi Date: Fri, 6 Jan 2012 15:51:25 +0000 Message-Id: <1325865088-23897-7-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1325865088-23897-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1325865088-23897-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 6/9] gdbstub: Fix fd leak in gdbserver_open() error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Anthony Liguori , Stefan Hajnoczi From: Peter Maydell Fix a leak of a file descriptor in error exit paths in gdbserver_open(). Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- gdbstub.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index a5806ef..7d470b6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2762,11 +2762,13 @@ static int gdbserver_open(int port) ret = bind(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)); if (ret < 0) { perror("bind"); + close(fd); return -1; } ret = listen(fd, 0); if (ret < 0) { perror("listen"); + close(fd); return -1; } return fd; -- 1.7.7.3