From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjC66-0003cj-GH for qemu-devel@nongnu.org; Fri, 06 Jan 2012 10:52:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjC65-0006Wg-6c for qemu-devel@nongnu.org; Fri, 06 Jan 2012 10:52:50 -0500 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:59062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjC64-0006WQ-S2 for qemu-devel@nongnu.org; Fri, 06 Jan 2012 10:52:49 -0500 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 6 Jan 2012 15:52:48 -0000 Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q06Fqjgf2699338 for ; Fri, 6 Jan 2012 15:52:45 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q06FqjfX006368 for ; Fri, 6 Jan 2012 08:52:45 -0700 From: Stefan Hajnoczi Date: Fri, 6 Jan 2012 15:51:26 +0000 Message-Id: <1325865088-23897-8-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1325865088-23897-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1325865088-23897-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 7/9] net/socket.c: Fix fd leak in net_socket_listen_init() error paths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Anthony Liguori , Stefan Hajnoczi From: Peter Maydell Fix a leak of a file descriptor due to missing closesocket() calls in error paths in net_socket_listen_init(). Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- net/socket.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/socket.c b/net/socket.c index aaf9be4..c9d70d3 100644 --- a/net/socket.c +++ b/net/socket.c @@ -427,12 +427,14 @@ static int net_socket_listen_init(VLANState *vlan, if (ret < 0) { perror("bind"); g_free(s); + closesocket(fd); return -1; } ret = listen(fd, 0); if (ret < 0) { perror("listen"); g_free(s); + closesocket(fd); return -1; } s->vlan = vlan; -- 1.7.7.3