qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: avi@redhat.com, gleb@redhat.com
Subject: [Qemu-devel] [PATCH qemu-kvm] Fix: SCI isn't sent on cpu hotplug
Date: Sun,  8 Jan 2012 22:40:04 +0100	[thread overview]
Message-ID: <1326058804-561-1-git-send-email-imammedo@redhat.com> (raw)

 Change introduced by e71f08bb4a
    "Fix cpu/pci hotplug to generate level triggered interrupt."
 was lost somewhre along the way. And as result SCI is not sent in
 case of cpu hotplug event.
 Restoring hunk 1 of e71f08bb4a fixes issue.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 hw/acpi_piix4.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index 1b35707..741a8cc 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -94,7 +94,8 @@ static void pm_update_sci(PIIX4PMState *s)
                    ACPI_BITMASK_POWER_BUTTON_ENABLE |
                    ACPI_BITMASK_GLOBAL_LOCK_ENABLE |
                    ACPI_BITMASK_TIMER_ENABLE)) != 0) ||
-        (((s->gpe.sts[0] & s->gpe.en[0]) & PIIX4_PCI_HOTPLUG_STATUS) != 0);
+        (((s->gpe.sts[0] & s->gpe.en[0]) &
+          (PIIX4_CPU_HOTPLUG_STATUS | PIIX4_PCI_HOTPLUG_STATUS)) != 0);
 
     qemu_set_irq(s->irq, sci_level);
     /* schedule a timer interruption if needed */
-- 
1.7.7.5

             reply	other threads:[~2012-01-08 21:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-08 21:40 Igor Mammedov [this message]
2012-01-09  8:47 ` [Qemu-devel] [PATCH qemu-kvm] Fix: SCI isn't sent on cpu hotplug Gleb Natapov
2012-01-09 10:03   ` Jan Kiszka
2012-01-09 10:07     ` Gleb Natapov
2012-01-09 10:19       ` Jan Kiszka
2012-01-09 11:07         ` Igor Mammedov
2012-01-09 11:15           ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326058804-561-1-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).