From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, aliguori@us.ibm.com, mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 06/10] monitor: expose readline state
Date: Mon, 9 Jan 2012 09:24:13 -0200 [thread overview]
Message-ID: <1326108257-13042-7-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1326108257-13042-1-git-send-email-lcapitulino@redhat.com>
From: Anthony Liguori <aliguori@us.ibm.com>
HMP is now implemented in terms of QMP. The monitor has a bunch of logic to
deal with HMP right now like readline support. Export it from the monitor so
we can consume it in hmp.c.
In short time, hmp.c will take over all of the readline bits.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
monitor.c | 11 ++++++++---
monitor.h | 5 +++++
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index aa7259c..bd4bc4f 100644
--- a/monitor.c
+++ b/monitor.c
@@ -227,7 +227,7 @@ int monitor_cur_is_qmp(void)
return cur_mon && monitor_ctrl_mode(cur_mon);
}
-static void monitor_read_command(Monitor *mon, int show_prompt)
+void monitor_read_command(Monitor *mon, int show_prompt)
{
if (!mon->rs)
return;
@@ -237,8 +237,8 @@ static void monitor_read_command(Monitor *mon, int show_prompt)
readline_show_prompt(mon->rs);
}
-static int monitor_read_password(Monitor *mon, ReadLineFunc *readline_func,
- void *opaque)
+int monitor_read_password(Monitor *mon, ReadLineFunc *readline_func,
+ void *opaque)
{
if (monitor_ctrl_mode(mon)) {
qerror_report(QERR_MISSING_PARAMETER, "password");
@@ -4664,6 +4664,11 @@ static void bdrv_password_cb(Monitor *mon, const char *password, void *opaque)
monitor_read_command(mon, 1);
}
+ReadLineState *monitor_get_rs(Monitor *mon)
+{
+ return mon->rs;
+}
+
int monitor_read_bdrv_key_start(Monitor *mon, BlockDriverState *bs,
BlockDriverCompletionFunc *completion_cb,
void *opaque)
diff --git a/monitor.h b/monitor.h
index cfa2f67..887c472 100644
--- a/monitor.h
+++ b/monitor.h
@@ -6,6 +6,7 @@
#include "qerror.h"
#include "qdict.h"
#include "block.h"
+#include "readline.h"
extern Monitor *cur_mon;
extern Monitor *default_mon;
@@ -66,6 +67,10 @@ int monitor_get_cpu_index(void);
typedef void (MonitorCompletion)(void *opaque, QObject *ret_data);
void monitor_set_error(Monitor *mon, QError *qerror);
+void monitor_read_command(Monitor *mon, int show_prompt);
+ReadLineState *monitor_get_rs(Monitor *mon);
+int monitor_read_password(Monitor *mon, ReadLineFunc *readline_func,
+ void *opaque);
int qmp_qom_set(Monitor *mon, const QDict *qdict, QObject **ret);
--
1.7.8.2.325.g247f9.dirty
next prev parent reply other threads:[~2012-01-09 11:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 11:24 [Qemu-devel] [PATCH v1 00/10]: QAPI conversions round 4 Luiz Capitulino
2012-01-09 11:24 ` [Qemu-devel] [PATCH 01/10] vnc: Simplify vnc_display_password() Luiz Capitulino
2012-01-09 11:24 ` [Qemu-devel] [PATCH 02/10] qapi: Convert set_password Luiz Capitulino
2012-01-09 11:24 ` [Qemu-devel] [PATCH 03/10] qapi: Convert expire_password Luiz Capitulino
2012-01-09 11:24 ` [Qemu-devel] [PATCH 04/10] block: eject_device(): Use error_set() Luiz Capitulino
2012-01-09 11:24 ` [Qemu-devel] [PATCH 05/10] qapi: Convert eject Luiz Capitulino
2012-01-09 11:24 ` Luiz Capitulino [this message]
2012-01-09 11:24 ` [Qemu-devel] [PATCH 07/10] qapi: Introduce change-vnc-password Luiz Capitulino
2012-01-09 11:24 ` [Qemu-devel] [PATCH 08/10] qerror: Extend QERR_DEVICE_ENCRYPTED Luiz Capitulino
2012-01-09 11:24 ` [Qemu-devel] [PATCH 09/10] qapi: Convert change Luiz Capitulino
2012-01-09 11:24 ` [Qemu-devel] [PATCH 10/10] qapi: Convert block_set_io_throttle Luiz Capitulino
2012-01-13 20:53 ` Anthony Liguori
2012-01-17 15:18 ` Luiz Capitulino
2012-01-17 15:30 ` Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326108257-13042-7-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).