From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"David Gibson" <dwg@au1.ibm.com>,
"Andreas Färber" <afaerber@suse.de>,
kvm-ppc@vger.kernel.org,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] virtio-pci: Fix endianness of virtio config
Date: Wed, 11 Jan 2012 09:10:48 +1100 [thread overview]
Message-ID: <1326233448.23910.74.camel@pasglop> (raw)
In-Reply-To: <1326233090.23910.71.camel@pasglop>
On Wed, 2012-01-11 at 09:04 +1100, Benjamin Herrenschmidt wrote:
> On Tue, 2012-01-10 at 22:45 +0100, Alexander Graf wrote:
> > Here's the thing that I don't understand. What exactly is breaking for
> > you? I tried -M pseries on a ppc box and on an x86 box and both times
> > was able to see /dev/vda.
>
> And mount it and use it ? Here I get the capacity wrong if I don't have
> my patch and can't actually boot a distro off it.
Hrm actually, it might well work with Linux regardless because Linux
only ever does 8 bit accesses to the virtio config space.
It's SLOF that breaks because SLOF uses 2 and 4 byte accesses (which are
allowed per spec as far as I can tell) but the spurrious swapping
happening in that case means we lost the byte address invariance.
Cheers,
Ben.
next prev parent reply other threads:[~2012-01-10 22:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 11:35 [Qemu-devel] [PATCH] virtio-pci: Fix endianness of virtio config Benjamin Herrenschmidt
2012-01-10 20:30 ` Alexander Graf
2012-01-10 20:35 ` Andreas Färber
2012-01-10 20:46 ` Alexander Graf
2012-01-10 21:04 ` Benjamin Herrenschmidt
2012-01-10 21:45 ` Alexander Graf
2012-01-10 22:04 ` Benjamin Herrenschmidt
2012-01-10 22:10 ` Benjamin Herrenschmidt [this message]
2012-01-10 22:02 ` Anthony Liguori
2012-01-10 22:41 ` Alexander Graf
2012-01-10 22:49 ` Benjamin Herrenschmidt
2012-01-10 22:52 ` Alexander Graf
2012-01-10 22:57 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326233448.23910.74.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=dwg@au1.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).