* [Qemu-devel] [PATCH] bt-host: add missing break statement
@ 2012-01-12 14:17 Stefan Hajnoczi
2012-01-12 17:44 ` Stefan Weil
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hajnoczi @ 2012-01-12 14:17 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, andrew.zaborowski, Stefan Hajnoczi
The switch statement in bt_host_read() is missing a break in one case.
Andrzej Zaborowski <andrew.zaborowski@intel.com> confirmed that this is
not an intentional fall-through.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
bt-host.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/bt-host.c b/bt-host.c
index df5b7cd..0d3ad28 100644
--- a/bt-host.c
+++ b/bt-host.c
@@ -130,6 +130,7 @@ static void bt_host_read(void *opaque)
pktlen = MIN(pkt[2] + 3, s->len);
s->len -= pktlen;
pkt += pktlen;
+ break;
default:
bad_pkt:
--
1.7.7.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] bt-host: add missing break statement
2012-01-12 14:17 [Qemu-devel] [PATCH] bt-host: add missing break statement Stefan Hajnoczi
@ 2012-01-12 17:44 ` Stefan Weil
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Weil @ 2012-01-12 17:44 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-trivial, andrew.zaborowski, qemu-devel
Am 12.01.2012 15:17, schrieb Stefan Hajnoczi:
> The switch statement in bt_host_read() is missing a break in one case.
> Andrzej Zaborowski <andrew.zaborowski@intel.com> confirmed that this is
> not an intentional fall-through.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
> bt-host.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/bt-host.c b/bt-host.c
> index df5b7cd..0d3ad28 100644
> --- a/bt-host.c
> +++ b/bt-host.c
> @@ -130,6 +130,7 @@ static void bt_host_read(void *opaque)
> pktlen = MIN(pkt[2] + 3, s->len);
> s->len -= pktlen;
> pkt += pktlen;
> + break;
>
> default:
> bad_pkt:
Reviewed-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-12 17:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-12 14:17 [Qemu-devel] [PATCH] bt-host: add missing break statement Stefan Hajnoczi
2012-01-12 17:44 ` Stefan Weil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).