qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <andreas.faerber@web.de>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <andreas.faerber@web.de>,
	qemu-ppc@nongnu.org, "Alexander Graf" <agraf@suse.de>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v3 2/8] prep_pci: Simplify I/O endianness
Date: Fri, 13 Jan 2012 04:09:22 +0100	[thread overview]
Message-ID: <1326424168-15705-3-git-send-email-andreas.faerber@web.de> (raw)
In-Reply-To: <1326424168-15705-1-git-send-email-andreas.faerber@web.de>

The prep PowerPC CPU is Big Endian. An explicit byte swap therefore
effectively becomes Little Endian.

Remove explicit byte swaps and mark as Little Endian.

Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: Alexander Graf <agraf@suse.de>
Cc: Michael S. Tsirkin <mst@redhat.com>
---
 hw/prep_pci.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/hw/prep_pci.c b/hw/prep_pci.c
index 741b273..edfb25d 100644
--- a/hw/prep_pci.c
+++ b/hw/prep_pci.c
@@ -53,14 +53,12 @@ static void PPC_PCIIO_writeb (void *opaque, target_phys_addr_t addr, uint32_t va
 static void PPC_PCIIO_writew (void *opaque, target_phys_addr_t addr, uint32_t val)
 {
     PREPPCIState *s = opaque;
-    val = bswap16(val);
     pci_data_write(s->bus, PPC_PCIIO_config(addr), val, 2);
 }
 
 static void PPC_PCIIO_writel (void *opaque, target_phys_addr_t addr, uint32_t val)
 {
     PREPPCIState *s = opaque;
-    val = bswap32(val);
     pci_data_write(s->bus, PPC_PCIIO_config(addr), val, 4);
 }
 
@@ -77,7 +75,6 @@ static uint32_t PPC_PCIIO_readw (void *opaque, target_phys_addr_t addr)
     PREPPCIState *s = opaque;
     uint32_t val;
     val = pci_data_read(s->bus, PPC_PCIIO_config(addr), 2);
-    val = bswap16(val);
     return val;
 }
 
@@ -86,7 +83,6 @@ static uint32_t PPC_PCIIO_readl (void *opaque, target_phys_addr_t addr)
     PREPPCIState *s = opaque;
     uint32_t val;
     val = pci_data_read(s->bus, PPC_PCIIO_config(addr), 4);
-    val = bswap32(val);
     return val;
 }
 
@@ -95,7 +91,7 @@ static const MemoryRegionOps PPC_PCIIO_ops = {
         .read = { PPC_PCIIO_readb, PPC_PCIIO_readw, PPC_PCIIO_readl, },
         .write = { PPC_PCIIO_writeb, PPC_PCIIO_writew, PPC_PCIIO_writel, },
     },
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
 };
 
 static int prep_map_irq(PCIDevice *pci_dev, int irq_num)
-- 
1.7.7

  parent reply	other threads:[~2012-01-13  3:11 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07  0:06 [Qemu-devel] [PATCH v2 0/3] qdev'ify PReP PCI host bridge Andreas Färber
2012-01-07  0:06 ` [Qemu-devel] [PATCH v2 1/3] prep: qdev'ify Raven " Andreas Färber
2012-01-11 22:00   ` Anthony Liguori
2012-01-07  0:06 ` [Qemu-devel] [PATCH v2 2/3] prep: Add Raven PCI host SysBus device Andreas Färber
2012-01-11 22:01   ` Anthony Liguori
2012-01-11 22:12   ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2012-01-11 22:24     ` Andreas Färber
2012-01-07  0:06 ` [Qemu-devel] [PATCH v2 3/3] MAINTAINERS: Add PCI host bridge files to PReP machine Andreas Färber
2012-01-11 21:57   ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2012-01-13  3:09 ` [Qemu-devel] [PATCH v3 0/8] qdev'ify PReP PCI host bridge and add PCI-to-ISA bridge Andreas Färber
2012-01-13  3:09   ` [Qemu-devel] [PATCH v3 1/8] prep: qdev'ify Raven host bridge (PCIDevice) Andreas Färber
2012-01-13  3:09   ` Andreas Färber [this message]
2012-01-13  3:09   ` [Qemu-devel] [PATCH v3 3/8] prep_pci: Update I/O to MemoryRegion ops Andreas Färber
2012-01-15  9:19     ` Avi Kivity
2012-01-16 15:08       ` Andreas Färber
2012-01-16 15:15         ` Avi Kivity
2012-01-13  3:09   ` [Qemu-devel] [PATCH v3 4/8] prep: qdev'ify Raven host bridge (SysBus) Andreas Färber
2012-01-13  3:09   ` [Qemu-devel] [PATCH v3 5/8] MAINTAINERS: Add PCI host bridge files to PReP machine Andreas Färber
2012-01-13  3:09   ` [Qemu-devel] [PATCH v3 6/8] prep: Add i82374 DMA emulation Andreas Färber
2012-01-13  3:09   ` [Qemu-devel] [PATCH v3 7/8] prep: Add i82378 PCI-to-ISA bridge emulation Andreas Färber
2012-01-13  3:09   ` [Qemu-devel] [PATCH v3 8/8] prep: Use i82378 PCI->ISA bridge for 'prep' machine Andreas Färber
2012-01-13  9:21     ` Jan Kiszka
2012-01-13 15:57       ` Andreas Färber
2012-01-13 16:08         ` Jan Kiszka
2012-01-13 16:23           ` Alexander Graf
2012-01-13 16:45             ` Jan Kiszka
2012-01-13  3:33   ` [Qemu-devel] [PATCH v3 0/8] qdev'ify PReP PCI host bridge and add PCI-to-ISA bridge Andreas Färber
2012-01-13 11:42   ` Alexander Graf
2012-01-13 19:03 ` [Qemu-devel] [PATCH v4 " Andreas Färber
2012-01-13 19:03   ` [Qemu-devel] [PATCH v4 1/8] prep: qdev'ify Raven host bridge (PCIDevice) Andreas Färber
2012-01-13 19:03   ` [Qemu-devel] [PATCH v4 2/8] prep_pci: Simplify I/O endianness Andreas Färber
2012-01-13 19:03   ` [Qemu-devel] [PATCH v4 3/8] prep_pci: Update I/O to MemoryRegion ops Andreas Färber
2012-01-13 19:03   ` [Qemu-devel] [PATCH v4 4/8] prep: qdev'ify Raven host bridge (SysBus) Andreas Färber
2012-01-13 19:03   ` [Qemu-devel] [PATCH v4 5/8] MAINTAINERS: Add PCI host bridge files to PReP machine Andreas Färber
2012-01-13 19:03   ` [Qemu-devel] [PATCH v4 6/8] prep: Add i82374 DMA emulation Andreas Färber
2012-01-13 19:03   ` [Qemu-devel] [PATCH v4 7/8] prep: Add i82378 PCI-to-ISA bridge emulation Andreas Färber
2012-01-13 19:03   ` [Qemu-devel] [PATCH v4 8/8] prep: Use i82378 PCI->ISA bridge for 'prep' machine Andreas Färber
2012-01-16 14:49   ` [Qemu-devel] [PATCH v4 0/8] qdev'ify PReP PCI host bridge and add PCI-to-ISA bridge Andreas Färber
2012-01-16 16:18 ` [Qemu-devel] [PATCH v5 0/6] " Andreas Färber
2012-01-16 16:18   ` [Qemu-devel] [PATCH v5 1/6] prep_pci: Update I/O to MemoryRegion ops Andreas Färber
2012-01-16 16:18   ` [Qemu-devel] [PATCH v5 2/6] prep: qdev'ify Raven host bridge (SysBus) Andreas Färber
2012-01-16 16:18   ` [Qemu-devel] [PATCH v5 3/6] MAINTAINERS: Add PCI host bridge files to PReP machine Andreas Färber
2012-01-16 16:18   ` [Qemu-devel] [PATCH v5 4/6] prep: Add i82374 DMA emulation Andreas Färber
2012-01-16 16:18   ` [Qemu-devel] [PATCH v5 5/6] prep: Add i82378 PCI-to-ISA bridge emulation Andreas Färber
2012-01-16 16:18   ` [Qemu-devel] [PATCH v5 6/6] prep: Use i82378 PCI->ISA bridge for 'prep' machine Andreas Färber
2012-01-19 23:40   ` [Qemu-devel] [PATCH v5 0/6] qdev'ify PReP PCI host bridge and add PCI-to-ISA bridge Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326424168-15705-3-git-send-email-andreas.faerber@web.de \
    --to=andreas.faerber@web.de \
    --cc=agraf@suse.de \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).