qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 08/12] hmp: Fix freeing of PciInfoList
Date: Fri, 13 Jan 2012 10:51:36 +0000	[thread overview]
Message-ID: <1326451900-18325-9-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1326451900-18325-1-git-send-email-stefanha@linux.vnet.ibm.com>

From: Stefan Berger <stefanb@linux.vnet.ibm.com>

Remember the original PciInfoList in info_list and use
the info variable to traverse the list.

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 hmp.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hmp.c b/hmp.c
index e7659d5..fd4f755 100644
--- a/hmp.c
+++ b/hmp.c
@@ -486,17 +486,17 @@ static void hmp_info_pci_device(Monitor *mon, const PciDeviceInfo *dev)
 
 void hmp_info_pci(Monitor *mon)
 {
-    PciInfoList *info;
+    PciInfoList *info_list, *info;
     Error *err = NULL;
 
-    info = qmp_query_pci(&err);
+    info_list = qmp_query_pci(&err);
     if (err) {
         monitor_printf(mon, "PCI devices not supported\n");
         error_free(err);
         return;
     }
 
-    for (; info; info = info->next) {
+    for (info = info_list; info; info = info->next) {
         PciDeviceInfoList *dev;
 
         for (dev = info->value->devices; dev; dev = dev->next) {
@@ -504,7 +504,7 @@ void hmp_info_pci(Monitor *mon)
         }
     }
 
-    qapi_free_PciInfoList(info);
+    qapi_free_PciInfoList(info_list);
 }
 
 void hmp_quit(Monitor *mon, const QDict *qdict)
-- 
1.7.7.3

  parent reply	other threads:[~2012-01-13 10:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-13 10:51 [Qemu-devel] [PULL 00/12] Trivial patches for 6 to 13 January 2012 Stefan Hajnoczi
2012-01-13 10:51 ` [Qemu-devel] [PATCH 01/12] configure: Modify detection of supported warning options Stefan Hajnoczi
2012-01-13 10:51 ` [Qemu-devel] [PATCH 02/12] tcg-arm: fix a typo in comments Stefan Hajnoczi
2012-01-13 10:51 ` [Qemu-devel] [PATCH 03/12] Spelling fixes in comments and documentation Stefan Hajnoczi
2012-01-13 10:51 ` [Qemu-devel] [PATCH 04/12] vvfat: avoid leaking file descriptor in commit_one_file() Stefan Hajnoczi
2012-01-13 10:51 ` [Qemu-devel] [PATCH 05/12] vnc: fix no-lock-key-sync strncmp() length Stefan Hajnoczi
2012-01-13 10:51 ` [Qemu-devel] [PATCH 06/12] omap_dss: correct chip[1] index in RFBI_READ/RFBI_STATUS Stefan Hajnoczi
2012-01-13 10:51 ` [Qemu-devel] [PATCH 07/12] Add 'fall through' comments to case statements without break Stefan Hajnoczi
2012-01-13 10:51 ` Stefan Hajnoczi [this message]
2012-01-13 10:51 ` [Qemu-devel] [PATCH 09/12] virtfs-proxy-helper: Fix compilation on newer systems Stefan Hajnoczi
2012-01-13 10:51 ` [Qemu-devel] [PATCH 10/12] virtfs-proxy-helper: Clean include files Stefan Hajnoczi
2012-01-13 10:51 ` [Qemu-devel] [PATCH 11/12] virtfs-proxy-helper: Add missing printf format attribute Stefan Hajnoczi
2012-01-13 10:51 ` [Qemu-devel] [PATCH 12/12] bt-host: add missing break statement Stefan Hajnoczi
2012-01-13 16:53 ` [Qemu-devel] [PULL 00/12] Trivial patches for 6 to 13 January 2012 Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326451900-18325-9-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).