From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlem2-0002W5-Ad for qemu-devel@nongnu.org; Fri, 13 Jan 2012 05:54:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rlelm-0001Ue-E4 for qemu-devel@nongnu.org; Fri, 13 Jan 2012 05:54:08 -0500 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:34647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlelm-0001Na-72 for qemu-devel@nongnu.org; Fri, 13 Jan 2012 05:54:02 -0500 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Jan 2012 10:53:16 -0000 Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0DAqtYI2592910 for ; Fri, 13 Jan 2012 10:52:55 GMT Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0DAqtC5018451 for ; Fri, 13 Jan 2012 03:52:55 -0700 From: Stefan Hajnoczi Date: Fri, 13 Jan 2012 10:51:36 +0000 Message-Id: <1326451900-18325-9-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1326451900-18325-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1326451900-18325-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 08/12] hmp: Fix freeing of PciInfoList List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Stefan Berger From: Stefan Berger Remember the original PciInfoList in info_list and use the info variable to traverse the list. Signed-off-by: Stefan Berger Signed-off-by: Stefan Hajnoczi --- hmp.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hmp.c b/hmp.c index e7659d5..fd4f755 100644 --- a/hmp.c +++ b/hmp.c @@ -486,17 +486,17 @@ static void hmp_info_pci_device(Monitor *mon, const PciDeviceInfo *dev) void hmp_info_pci(Monitor *mon) { - PciInfoList *info; + PciInfoList *info_list, *info; Error *err = NULL; - info = qmp_query_pci(&err); + info_list = qmp_query_pci(&err); if (err) { monitor_printf(mon, "PCI devices not supported\n"); error_free(err); return; } - for (; info; info = info->next) { + for (info = info_list; info; info = info->next) { PciDeviceInfoList *dev; for (dev = info->value->devices; dev; dev = dev->next) { @@ -504,7 +504,7 @@ void hmp_info_pci(Monitor *mon) } } - qapi_free_PciInfoList(info); + qapi_free_PciInfoList(info_list); } void hmp_quit(Monitor *mon, const QDict *qdict) -- 1.7.7.3