From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlhSL-0002vx-QJ for qemu-devel@nongnu.org; Fri, 13 Jan 2012 08:46:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlhSH-00048Q-Dp for qemu-devel@nongnu.org; Fri, 13 Jan 2012 08:46:09 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:45597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlhSH-00048F-78 for qemu-devel@nongnu.org; Fri, 13 Jan 2012 08:46:05 -0500 Received: from /spool/local by e2.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Jan 2012 08:46:04 -0500 Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0DDk0Kj348646 for ; Fri, 13 Jan 2012 08:46:01 -0500 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0DDk0Xr031711 for ; Fri, 13 Jan 2012 06:46:00 -0700 From: Anthony Liguori Date: Fri, 13 Jan 2012 07:45:55 -0600 Message-Id: <1326462355-8203-1-git-send-email-aliguori@us.ibm.com> Subject: [Qemu-devel] [PATCH] qdev: fix device_del by refactoring reference counting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Markus Armbruster Commit 8eb0283 broken device_del by having too overzealous reference counting checks. Move the reference count checks to qdev_free(), make sure to remove the parent link on free, and decrement the reference count on property removal. Reported-by: Markus Armbruster Signed-off-by: Anthony Liguori --- hw/qdev.c | 45 +++++++++++++++++++++++++++++++++++++++------ 1 files changed, 39 insertions(+), 6 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index d0cf66d..e59f345 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -376,11 +376,6 @@ int qdev_unplug(DeviceState *dev) } assert(dev->info->unplug != NULL); - if (dev->ref != 0) { - qerror_report(QERR_DEVICE_IN_USE, dev->id?:""); - return -1; - } - qdev_hot_removed = true; return dev->info->unplug(dev); @@ -465,6 +460,29 @@ static void qdev_property_del_all(DeviceState *dev) } } +static void qdev_property_del_child(DeviceState *dev, DeviceState *child, Error **errp) +{ + DeviceProperty *prop; + + QTAILQ_FOREACH(prop, &dev->properties, node) { + if (strstart(prop->type, "child<", NULL) && prop->opaque == child) { + break; + } + } + + g_assert(prop != NULL); + + QTAILQ_REMOVE(&dev->properties, prop, node); + + if (prop->release) { + prop->release(dev, prop->name, prop->opaque); + } + + g_free(prop->name); + g_free(prop->type); + g_free(prop); +} + /* Unlink device from bus and free the structure. */ void qdev_free(DeviceState *dev) { @@ -491,6 +509,12 @@ void qdev_free(DeviceState *dev) prop->info->free(dev, prop); } } + if (dev->parent) { + qdev_property_del_child(dev->parent, dev, NULL); + } + if (dev->ref != 0) { + qerror_report(QERR_DEVICE_IN_USE, dev->id?:""); + } g_free(dev); } @@ -1239,6 +1263,14 @@ static void qdev_get_child_property(DeviceState *dev, Visitor *v, void *opaque, g_free(path); } +static void qdev_release_child_property(DeviceState *dev, const char *name, + void *opaque) +{ + DeviceState *child = opaque; + + qdev_unref(child); +} + void qdev_property_add_child(DeviceState *dev, const char *name, DeviceState *child, Error **errp) { @@ -1247,7 +1279,8 @@ void qdev_property_add_child(DeviceState *dev, const char *name, type = g_strdup_printf("child<%s>", child->info->name); qdev_property_add(dev, name, type, qdev_get_child_property, - NULL, NULL, child, errp); + NULL, qdev_release_child_property, + child, errp); qdev_ref(child); g_assert(child->parent == NULL); -- 1.7.4.1