From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH] kvm: flush the dirty log when unregistering a slot
Date: Sun, 15 Jan 2012 16:17:31 +0200 [thread overview]
Message-ID: <1326637051-23920-1-git-send-email-avi@redhat.com> (raw)
Otherwise, the dirty log information is lost in the kernel forever.
Fixes opensuse-12.1 boot screen, which changes the vga windows rapidly.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
This patch gives me a deja vu - I'm sure I've fixed exactly the same issue
before.
Please test.
kvm-all.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 3174f42..2cc4562 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -566,6 +566,10 @@ static void kvm_set_phys_mem(MemoryRegionSection *section, bool add)
old = *mem;
+ if (mem->flags & KVM_MEM_LOG_DIRTY_PAGES) {
+ kvm_physical_sync_dirty_bitmap(section);
+ }
+
/* unregister the overlapping slot */
mem->memory_size = 0;
err = kvm_set_user_memory_region(s, mem);
--
1.7.7.1
next reply other threads:[~2012-01-15 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 14:17 Avi Kivity [this message]
2012-01-15 14:26 ` [Qemu-devel] [PATCH] kvm: flush the dirty log when unregistering a slot Jan Kiszka
2012-01-15 14:40 ` Gerhard Wiesinger
2012-01-15 17:01 ` Avi Kivity
2012-01-25 20:15 ` Gerhard Wiesinger
2012-01-26 12:29 ` Avi Kivity
2012-01-27 6:50 ` Gerhard Wiesinger
2012-01-29 10:15 ` Avi Kivity
2012-01-17 11:25 ` Marcelo Tosatti
2012-01-17 12:28 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326637051-23920-1-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).