From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmrO0-0005ts-OU for qemu-devel@nongnu.org; Mon, 16 Jan 2012 13:34:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmrNz-0005K4-N1 for qemu-devel@nongnu.org; Mon, 16 Jan 2012 13:34:28 -0500 Received: from mnementh.archaic.org.uk ([81.2.115.146]:39838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmrNz-0005JZ-GV for qemu-devel@nongnu.org; Mon, 16 Jan 2012 13:34:27 -0500 From: Peter Maydell Date: Mon, 16 Jan 2012 18:34:16 +0000 Message-Id: <1326738858-19992-2-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1326738858-19992-1-git-send-email-peter.maydell@linaro.org> References: <1326738858-19992-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 1/3] target-arm/helper.c: Don't assume softfloat int32 is 32 bits only List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= , patches@linaro.org In the helper routines for VCVT float-to-int conversions, add an explicit cast rather than relying on the softfloat int32 type being exactly 32 bits wide (which it is not guaranteed to be). Without this, if the softfloat type was 64 bits wide we would get zero-extension of the 32 bit value from the ARM register rather than sign-extension, since TCG i32 values are passed as uint32_t. Signed-off-by: Peter Maydell --- target-arm/helper.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 00458fc..e968c9c 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2786,7 +2786,7 @@ DO_VFP_cmp(d, float64) float##fsz HELPER(name)(uint32_t x, void *fpstp) \ { \ float_status *fpst = fpstp; \ - return sign##int32_to_##float##fsz(x, fpst); \ + return sign##int32_to_##float##fsz((sign##int32_t)x, fpst); \ } #define CONV_FTOI(name, fsz, sign, round) \ -- 1.7.1