qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <andreas.faerber@web.de>
To: qemu-devel@nongnu.org
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
	"Jan Kiszka" <jan.kiszka@siemens.com>,
	"Blue Swirl" <blauwirbel@gmail.com>,
	"Andreas Färber" <andreas.faerber@web.de>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Avi Kivity" <avi@redhat.com>,
	qemu-ppc@nongnu.org, "Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 02/10] prep: Use ISA m48t59
Date: Fri, 20 Jan 2012 00:35:23 +0100	[thread overview]
Message-ID: <1327016131-5344-3-git-send-email-andreas.faerber@web.de> (raw)
In-Reply-To: <1327016131-5344-1-git-send-email-andreas.faerber@web.de>

This simplifies the code later when the i8259 moves to the i82378
PCI->ISA bridge and happens to fix a SysBus m48t59 io_base issue
introduced by commit 0fb56ffc5edd66f12ccfc0d71af5f9c79c0a2612 (m48t59:
drop obsolete address base arithmetic). Suggested by Hervé and Jan.

Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: Hervé Poussineau <hpoussin@reactos.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Blue Swirl <blauwirbel@gmail.com>
---
 hw/ppc_prep.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c
index dec059a..1cc0ae0 100644
--- a/hw/ppc_prep.c
+++ b/hw/ppc_prep.c
@@ -707,7 +707,7 @@ static void ppc_prep_init (ram_addr_t ram_size,
         usb_ohci_init_pci(pci_bus, -1);
     }
 
-    m48t59 = m48t59_init(i8259[8], 0, 0x0074, NVRAM_SIZE, 59);
+    m48t59 = m48t59_init_isa(isa_bus, 0x0074, NVRAM_SIZE, 59);
     if (m48t59 == NULL)
         return;
     sysctrl->nvram = m48t59;
-- 
1.7.7

  parent reply	other threads:[~2012-01-19 23:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19 23:35 [Qemu-devel] [PULL] PReP patch queue 2012-01-20 Andreas Färber
2012-01-19 23:35 ` [Qemu-devel] [PATCH 01/10] prep: Fix offset of BIOS MemoryRegion Andreas Färber
2012-01-19 23:35 ` Andreas Färber [this message]
2012-01-19 23:35 ` [Qemu-devel] [PATCH 03/10] prep: qdev'ify Raven host bridge (PCIDevice) Andreas Färber
2012-01-19 23:35 ` [Qemu-devel] [PATCH 04/10] prep_pci: Simplify I/O endianness Andreas Färber
2012-01-19 23:35 ` [Qemu-devel] [PATCH 05/10] prep_pci: Update I/O to MemoryRegion ops Andreas Färber
2012-01-19 23:35 ` [Qemu-devel] [PATCH 06/10] prep: qdev'ify Raven host bridge (SysBus) Andreas Färber
2012-01-19 23:35 ` [Qemu-devel] [PATCH 07/10] MAINTAINERS: Add PCI host bridge files to PReP machine Andreas Färber
2012-01-19 23:35 ` [Qemu-devel] [PATCH 08/10] prep: Add i82374 DMA emulation Andreas Färber
2012-01-19 23:35 ` [Qemu-devel] [PATCH 09/10] prep: Add i82378 PCI-to-ISA bridge emulation Andreas Färber
2012-01-19 23:35 ` [Qemu-devel] [PATCH 10/10] prep: Use i82378 PCI->ISA bridge for 'prep' machine Andreas Färber
2012-01-23 17:44 ` [Qemu-devel] [PULL] PReP patch queue 2012-01-20 Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327016131-5344-3-git-send-email-andreas.faerber@web.de \
    --to=andreas.faerber@web.de \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=hpoussin@reactos.org \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).