qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	jan.kiszka@siemens.com, qemu-devel@nongnu.org, avi@redhat.com,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [Qemu-devel] [PATCH v4 4/6] cirrus_vga: do not reset videoram on resume
Date: Fri, 20 Jan 2012 17:21:23 +0000	[thread overview]
Message-ID: <1327080085-8673-4-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1201201457040.3196@kaball-desktop>

From: Anthony PERARD <anthony.perard@citrix.com>

When resuming we shouldn't set the videoram to 0xff considering that we
are about to read it from the savefile.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 hw/cirrus_vga.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index f7b1d3d..eec2fc0 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -32,6 +32,7 @@
 #include "console.h"
 #include "vga_int.h"
 #include "loader.h"
+#include "sysemu.h"
 
 /*
  * TODO:
@@ -2760,9 +2761,11 @@ static void cirrus_reset(void *opaque)
     }
     s->vga.cr[0x27] = s->device_id;
 
-    /* Win2K seems to assume that the pattern buffer is at 0xff
-       initially ! */
-    memset(s->vga.vram_ptr, 0xff, s->real_vram_size);
+    if (!runstate_check(RUN_STATE_INMIGRATE)) {
+        /* Win2K seems to assume that the pattern buffer is at 0xff
+           initially ! */
+        memset(s->vga.vram_ptr, 0xff, s->real_vram_size);
+    }
 
     s->cirrus_hidden_dac_lockindex = 5;
     s->cirrus_hidden_dac_data = 0;
-- 
1.7.2.5

  parent reply	other threads:[~2012-01-20 17:21 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20 17:20 [Qemu-devel] [PATCH v4 0/6] save/restore on Xen Stefano Stabellini
2012-01-20 17:21 ` [Qemu-devel] [PATCH v4 1/6] vl.c: do not save the RAM state when Xen is enabled Stefano Stabellini
2012-01-23 15:58   ` Anthony Liguori
2012-01-20 17:21 ` [Qemu-devel] [PATCH v4 2/6] xen mapcache: check if memory region has moved Stefano Stabellini
2012-01-20 17:21 ` [Qemu-devel] [PATCH v4 3/6] Set runstate to INMIGRATE earlier Stefano Stabellini
2012-01-20 17:21 ` Stefano Stabellini [this message]
2012-01-20 17:21 ` [Qemu-devel] [PATCH v4 5/6] xen: record physmap changes to xenstore Stefano Stabellini
2012-01-20 17:21 ` [Qemu-devel] [PATCH v4 6/6] xen: change memory access behavior during migration Stefano Stabellini
2012-01-20 17:59 ` [Qemu-devel] [PATCH v4 0/6] save/restore on Xen Jan Kiszka
2012-01-23 10:47   ` Stefano Stabellini
2012-01-23 11:50     ` Jan Kiszka
2012-01-23 11:59       ` Stefano Stabellini
2012-01-23 12:10         ` Jan Kiszka
2012-01-23 14:46           ` Stefano Stabellini
2012-01-23 15:46             ` Jan Kiszka
2012-01-23 16:16               ` Stefano Stabellini
2012-01-23 16:22                 ` Anthony Liguori
2012-01-23 17:13                 ` Jan Kiszka
2012-01-23 17:18                   ` Anthony Liguori
2012-01-23 17:31                     ` Jan Kiszka
2012-01-23 17:36                       ` Anthony Liguori
2012-01-24 10:21                         ` Gerd Hoffmann
2012-01-24 11:13                           ` Avi Kivity
2012-01-24 12:00                             ` Stefano Stabellini
2012-01-24 15:39                               ` Avi Kivity
2012-01-24 13:18                             ` Anthony Liguori
2012-01-24 15:43                               ` Avi Kivity
2012-01-24 13:25                           ` Anthony Liguori
2012-01-24 15:47                             ` Avi Kivity
2012-01-24 11:10                     ` Avi Kivity
2012-01-24 11:27                       ` Paolo Bonzini
2012-01-24 11:32                         ` Avi Kivity
2012-01-24 11:44                           ` Paolo Bonzini
2012-01-24 15:48                             ` Avi Kivity
2012-01-24 11:52                           ` Stefano Stabellini
2012-01-24 13:15                             ` Anthony Liguori
2012-01-24 13:14                       ` Anthony Liguori
2012-01-24 15:56                         ` Avi Kivity
2012-01-24 17:51                           ` Anthony Liguori
2012-01-23 16:00     ` Anthony Liguori
2012-01-23 16:46       ` Stefano Stabellini
2012-01-23 16:54         ` Anthony Liguori
2012-01-23 17:05           ` Stefano Stabellini
2012-01-23 17:07             ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327080085-8673-4-git-send-email-stefano.stabellini@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).