From: "Hervé Poussineau" <hpoussin@reactos.org>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PATCH v3 2/9] fdc: set busy bit when starting a command
Date: Mon, 23 Jan 2012 09:50:33 +0100 [thread overview]
Message-ID: <1327308641-14736-3-git-send-email-hpoussin@reactos.org> (raw)
In-Reply-To: <1327308641-14736-1-git-send-email-hpoussin@reactos.org>
This bit must be active while a command is currently executed.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/fdc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/fdc.c b/hw/fdc.c
index c1898a6..1b9f303 100644
--- a/hw/fdc.c
+++ b/hw/fdc.c
@@ -1446,7 +1446,6 @@ static void fdctrl_handle_readid(FDCtrl *fdctrl, int direction)
{
FDrive *cur_drv = get_cur_drv(fdctrl);
- /* XXX: should set main status register to busy */
cur_drv->head = (fdctrl->fifo[1] >> 2) & 1;
qemu_mod_timer(fdctrl->result_timer,
qemu_get_clock_ns(vm_clock) + (get_ticks_per_sec() / 50));
@@ -1734,6 +1733,7 @@ static void fdctrl_write_data(FDCtrl *fdctrl, uint32_t value)
pos = command_to_handler[value & 0xff];
FLOPPY_DPRINTF("%s command\n", handlers[pos].name);
fdctrl->data_len = handlers[pos].parameters + 1;
+ fdctrl->msr |= FD_MSR_CMDBUSY;
}
FLOPPY_DPRINTF("%s: %02x\n", __func__, value);
--
1.7.7.3
next prev parent reply other threads:[~2012-01-23 8:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 8:50 [Qemu-devel] [PATCH v3 0/9] Misc fixes for floppy emulation Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 1/9] fdc: take side count into account Hervé Poussineau
2012-01-27 8:38 ` Markus Armbruster
2012-01-27 20:11 ` Hervé Poussineau
2012-01-31 9:28 ` Markus Armbruster
2012-01-31 22:24 ` Hervé Poussineau
2012-01-23 8:50 ` Hervé Poussineau [this message]
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 3/9] fdc: most control commands do not generate interrupts Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 4/9] fdc: handle read-only floppies (abort early on write commands) Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register Hervé Poussineau
2012-01-27 8:43 ` Markus Armbruster
2012-01-27 20:03 ` Hervé Poussineau
2012-01-31 9:31 ` Markus Armbruster
2012-01-31 22:16 ` Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 6/9] block: add a transfer rate for floppy types Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 7/9] fdc: check if media rate is correct before doing any transfer Hervé Poussineau
2012-01-27 8:56 ` Markus Armbruster
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 8/9] fdc: fix seek command, which shouldn't check tracks Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 9/9] fdc: DIR (Digital Input Register) should return status of current drive Hervé Poussineau
2012-01-27 8:57 ` Markus Armbruster
2012-01-31 9:34 ` [Qemu-devel] [PATCH v3 0/9] Misc fixes for floppy emulation Markus Armbruster
2012-01-31 22:22 ` Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327308641-14736-3-git-send-email-hpoussin@reactos.org \
--to=hpoussin@reactos.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).