From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpmUf-0002Ol-OZ for qemu-devel@nongnu.org; Tue, 24 Jan 2012 14:57:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpmTl-0007PM-C0 for qemu-devel@nongnu.org; Tue, 24 Jan 2012 14:56:30 -0500 Received: from e9.ny.us.ibm.com ([32.97.182.139]:59073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpmTl-0007PG-9U for qemu-devel@nongnu.org; Tue, 24 Jan 2012 14:56:29 -0500 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Jan 2012 14:56:28 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 7748638C8052 for ; Tue, 24 Jan 2012 14:56:22 -0500 (EST) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0OJZZGY161466 for ; Tue, 24 Jan 2012 14:55:05 -0500 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0OJXXal007905 for ; Tue, 24 Jan 2012 12:33:34 -0700 From: Anthony Liguori Date: Tue, 24 Jan 2012 13:33:00 -0600 Message-Id: <1327433600-7403-9-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1327433600-7403-1-git-send-email-aliguori@us.ibm.com> References: <1327433600-7403-1-git-send-email-aliguori@us.ibm.com> Subject: [Qemu-devel] [PATCH 08/28] qdev: use a wrapper to access reset and promote reset to a class method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Anthony Liguori , Paul Brook Signed-off-by: Anthony Liguori --- hw/intel-hda.c | 4 +--- hw/lsi53c895a.c | 2 +- hw/qdev.c | 22 +++++++++++++++++----- hw/qdev.h | 8 ++++++++ 4 files changed, 27 insertions(+), 9 deletions(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index 8cb92d3..6e1c5de 100644 --- a/hw/intel-hda.c +++ b/hw/intel-hda.c @@ -1116,9 +1116,7 @@ static void intel_hda_reset(DeviceState *dev) /* reset codecs */ QTAILQ_FOREACH(qdev, &d->codecs.qbus.children, sibling) { cdev = DO_UPCAST(HDACodecDevice, qdev, qdev); - if (qdev_get_info(qdev)->reset) { - qdev_get_info(qdev)->reset(qdev); - } + device_reset(DEVICE(cdev)); d->state_sts |= (1 << cdev->cad); } intel_hda_update_irq(d); diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index 9f475e0..3a87171 100644 --- a/hw/lsi53c895a.c +++ b/hw/lsi53c895a.c @@ -1681,7 +1681,7 @@ static void lsi_reg_writeb(LSIState *s, int offset, uint8_t val) DeviceState *dev; QTAILQ_FOREACH(dev, &s->bus.qbus.children, sibling) { - qdev_get_info(dev)->reset(dev); + device_reset(dev); } s->sstat0 |= LSI_SSTAT0_RST; lsi_script_scsi_interrupt(s, LSI_SIST0_RST, 0); diff --git a/hw/qdev.c b/hw/qdev.c index 5da94a8..a80ca7c 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -48,7 +48,12 @@ static BusState *qbus_find(const char *path); static void qdev_subclass_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); + dc->info = data; + dc->reset = dc->info->reset; + + /* Poison to try to detect future uses */ + dc->info->reset = NULL; } DeviceInfo *qdev_get_info(DeviceState *dev) @@ -378,8 +383,8 @@ int qdev_init(DeviceState *dev) dev->alias_required_for_version); } dev->state = DEV_STATE_INITIALIZED; - if (dev->hotplugged && qdev_get_info(dev)->reset) { - qdev_get_info(dev)->reset(dev); + if (dev->hotplugged) { + device_reset(dev); } return 0; } @@ -407,9 +412,7 @@ int qdev_unplug(DeviceState *dev) static int qdev_reset_one(DeviceState *dev, void *opaque) { - if (qdev_get_info(dev)->reset) { - qdev_get_info(dev)->reset(dev); - } + device_reset(dev); return 0; } @@ -1593,6 +1596,15 @@ void qdev_machine_init(void) qdev_get_peripheral(); } +void device_reset(DeviceState *dev) +{ + DeviceClass *klass = DEVICE_GET_CLASS(dev); + + if (klass->reset) { + klass->reset(dev); + } +} + static TypeInfo device_type_info = { .name = TYPE_DEVICE, .parent = TYPE_OBJECT, diff --git a/hw/qdev.h b/hw/qdev.h index a6af632..f3c9219 100644 --- a/hw/qdev.h +++ b/hw/qdev.h @@ -75,6 +75,7 @@ typedef struct DeviceProperty typedef struct DeviceClass { ObjectClass parent_class; DeviceInfo *info; + void (*reset)(DeviceState *dev); } DeviceClass; /* This structure should not be accessed directly. We declare it here @@ -647,4 +648,11 @@ char *qdev_get_type(DeviceState *dev, Error **errp); */ void qdev_machine_init(void); +/** + * @device_reset + * + * Reset a single device (by calling the reset method). + */ +void device_reset(DeviceState *dev); + #endif -- 1.7.4.1