From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH 5/6] qemu-ga: set O_NONBLOCK for serial channels
Date: Wed, 25 Jan 2012 09:26:25 -0600 [thread overview]
Message-ID: <1327505186-18328-6-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1327505186-18328-1-git-send-email-mdroth@linux.vnet.ibm.com>
From: Luiz Capitulino <lcapitulino@redhat.com>
This fixes a bug when using -m isa-serial where qemu-ga will
hang on a read()'s when communicating to the host via isa-serial.
Original fix by Michael Roth.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
qemu-ga.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-ga.c b/qemu-ga.c
index 8e5b075..d63b17c 100644
--- a/qemu-ga.c
+++ b/qemu-ga.c
@@ -544,7 +544,7 @@ static void init_guest_agent(GAState *s)
exit(EXIT_FAILURE);
}
} else if (strcmp(s->method, "isa-serial") == 0) {
- fd = qemu_open(s->path, O_RDWR | O_NOCTTY);
+ fd = qemu_open(s->path, O_RDWR | O_NOCTTY | O_NONBLOCK);
if (fd == -1) {
g_critical("error opening channel: %s", strerror(errno));
exit(EXIT_FAILURE);
--
1.7.4.1
next prev parent reply other threads:[~2012-01-25 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 15:26 [Qemu-devel] [PULL 0/6] qemu-ga queue and qemu-tool fixes Michael Roth
2012-01-25 15:26 ` [Qemu-devel] [PATCH 1/6] main-loop: Fix SetEvent() on uninitialized handle on win32 Michael Roth
2012-01-25 15:26 ` [Qemu-devel] [PATCH 2/6] main-loop: For tools, initialize timers as part of qemu_init_main_loop() Michael Roth
2012-01-25 15:26 ` [Qemu-devel] [PATCH 3/6] qemu-ga: Add schema documentation for types Michael Roth
2012-01-25 15:26 ` [Qemu-devel] [PATCH 4/6] qemu-ga: add guest-set-support-level command Michael Roth
2012-01-25 15:26 ` Michael Roth [this message]
2012-01-25 15:26 ` [Qemu-devel] [PATCH 6/6] qemu-ga: Add the guest-suspend command Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327505186-18328-6-git-send-email-mdroth@linux.vnet.ibm.com \
--to=mdroth@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).