From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqgEX-0005zT-Sd for qemu-devel@nongnu.org; Fri, 27 Jan 2012 02:28:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqgEW-0008T6-Cs for qemu-devel@nongnu.org; Fri, 27 Jan 2012 02:28:29 -0500 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:57034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqgEV-0008T1-W1 for qemu-devel@nongnu.org; Fri, 27 Jan 2012 02:28:28 -0500 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 27 Jan 2012 07:28:27 -0000 Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0R7SOkg2347162 for ; Fri, 27 Jan 2012 07:28:24 GMT Received: from d06av12.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0R7SO8v004987 for ; Fri, 27 Jan 2012 00:28:24 -0700 From: Stefan Hajnoczi Date: Fri, 27 Jan 2012 07:27:58 +0000 Message-Id: <1327649282-12431-3-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1327649282-12431-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1327649282-12431-1-git-send-email-stefanha@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 2/6] qdev-property: Make bit property parsing stricter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Jan Kiszka , Jan Kiszka , qemu-devel@nongnu.org, Stefan Hajnoczi From: Jan Kiszka By using strncasecmp, we allow for arbitrary characters after the "on"/"off" string. Fix this by switching to strcasecmp. Reviewed-by: Andreas Färber Reviewed-by: Markus Armbruster Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- hw/qdev-properties.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 02f0dae..ea3b2df 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -40,9 +40,9 @@ static void qdev_prop_cpy(DeviceState *dev, Property *props, void *src) /* Bit */ static int parse_bit(DeviceState *dev, Property *prop, const char *str) { - if (!strncasecmp(str, "on", 2)) + if (!strcasecmp(str, "on")) bit_prop_set(dev, prop, true); - else if (!strncasecmp(str, "off", 3)) + else if (!strcasecmp(str, "off")) bit_prop_set(dev, prop, false); else return -EINVAL; -- 1.7.8.3