From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqlvF-0007nM-S4 for qemu-devel@nongnu.org; Fri, 27 Jan 2012 08:33:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqlvA-0004dl-8x for qemu-devel@nongnu.org; Fri, 27 Jan 2012 08:32:57 -0500 From: Laszlo Ersek Date: Fri, 27 Jan 2012 14:34:05 +0100 Message-Id: <1327671245-5231-1-git-send-email-lersek@redhat.com> In-Reply-To: References: Subject: [Qemu-devel] [PATCH v2] keep the PID file locked for the lifetime of the process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, armbru@redhat.com The lockf() call in qemu_create_pidfile() aims at ensuring mutual exclusion. We shouldn't close the pidfile on success (as introduced by commit 1bbd1592), because that drops the lock as well [1]: "File locks shall be released on first close by the locking process of any file descriptor for the file." Coverity may complain again about the leaked file descriptor; let's worry about that later. v1->v2: - add reference to 1bbd1592 - explain the intentional fd leak in the source [1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/lockf.html Signed-off-by: Laszlo Ersek --- os-posix.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/os-posix.c b/os-posix.c index 5c437ca..e3ed497 100644 --- a/os-posix.c +++ b/os-posix.c @@ -348,6 +348,6 @@ int qemu_create_pidfile(const char *filename) return -1; } - close(fd); + /* keep pidfile open & locked forever */ return 0; } -- 1.7.1