qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 4/4] malta: Fix display for LED array
Date: Sat, 28 Jan 2012 16:18:19 +0100	[thread overview]
Message-ID: <1327763899-13354-5-git-send-email-sw@weilnetz.de> (raw)
In-Reply-To: <1327763899-13354-1-git-send-email-sw@weilnetz.de>

The 8-LED array was already implemented in the first commit to Malta,
but this implementation was incomplete.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 hw/mips_malta.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/mips_malta.c b/hw/mips_malta.c
index ce25690..90cfc9b 100644
--- a/hw/mips_malta.c
+++ b/hw/mips_malta.c
@@ -338,9 +338,9 @@ static void malta_fpga_write(void *opaque, target_phys_addr_t addr,
         break;
 
     /* LEDBAR Register */
-    /* XXX: implement a 8-LED array */
     case 0x00408:
         s->leds = val & 0xff;
+        malta_fpga_update_display(s);
         break;
 
     /* ASCIIWORD Register */
-- 
1.7.2.5

      parent reply	other threads:[~2012-01-28 15:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-28 15:18 [Qemu-devel] [PATCH 0/4] malta: Code updates for BIOS memory (flash) and LED array Stefan Weil
2012-01-28 15:18 ` [Qemu-devel] [PATCH 1/4] malta: Clean allocation of bios region alias Stefan Weil
2012-01-28 15:18 ` [Qemu-devel] [PATCH 2/4] malta: Always allocate flash memory Stefan Weil
2012-01-28 15:18 ` [Qemu-devel] [PATCH 3/4] malta: Use symbolic hardware addresses Stefan Weil
2012-01-28 15:18 ` Stefan Weil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327763899-13354-5-git-send-email-sw@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).