qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-ppc@nongnu.org
Cc: qemu-devel Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH 4/7] PPC: Enable doorbell excp handlers
Date: Tue, 31 Jan 2012 03:27:41 +0100	[thread overview]
Message-ID: <1327976864-30308-5-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1327976864-30308-1-git-send-email-agraf@suse.de>

We already had all the code available to have doorbell exceptions
be handled properly. It was just disabled.

Enable it, so we can rely on it.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 target-ppc/helper.c |   16 ++--------------
 1 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/target-ppc/helper.c b/target-ppc/helper.c
index 31a9897..e56fac8 100644
--- a/target-ppc/helper.c
+++ b/target-ppc/helper.c
@@ -2698,22 +2698,10 @@ static inline void powerpc_excp(CPUState *env, int excp_model, int excp)
                   "Performance counter exception is not implemented yet !\n");
         goto store_next;
     case POWERPC_EXCP_DOORI:     /* Embedded doorbell interrupt              */
-        /* XXX: TODO */
-        cpu_abort(env,
-                  "Embedded doorbell interrupt is not implemented yet !\n");
         goto store_next;
     case POWERPC_EXCP_DOORCI:    /* Embedded doorbell critical interrupt     */
-        switch (excp_model) {
-        case POWERPC_EXCP_BOOKE:
-            srr0 = SPR_BOOKE_CSRR0;
-            srr1 = SPR_BOOKE_CSRR1;
-            break;
-        default:
-            break;
-        }
-        /* XXX: TODO */
-        cpu_abort(env, "Embedded doorbell critical interrupt "
-                  "is not implemented yet !\n");
+        srr0 = SPR_BOOKE_CSRR0;
+        srr1 = SPR_BOOKE_CSRR1;
         goto store_next;
     case POWERPC_EXCP_RESET:     /* System reset exception                   */
         if (msr_pow) {
-- 
1.6.0.2

  parent reply	other threads:[~2012-01-31  2:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-31  2:27 [Qemu-devel] [PATCH 0/7] Enable doorbell for e500mc Alexander Graf
2012-01-31  2:27 ` [Qemu-devel] [PATCH 1/7] PPC: E500: Add some more excp vectors Alexander Graf
2012-01-31  2:27 ` [Qemu-devel] [PATCH 2/7] PPC: E500: Add doorbell defines Alexander Graf
2012-01-31  2:27 ` [Qemu-devel] [PATCH 3/7] PPC: Add CPU feature for processor control Alexander Graf
2012-01-31  2:27 ` Alexander Graf [this message]
2012-01-31  2:27 ` [Qemu-devel] [PATCH 5/7] PPC: E500: Implement msgclr Alexander Graf
2012-01-31  2:27 ` [Qemu-devel] [PATCH 6/7] PPC: E500: Implement msgsnd Alexander Graf
2012-01-31  2:27 ` [Qemu-devel] [PATCH 7/7] PPC: e500mc: Enable processor control Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327976864-30308-5-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).