qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: mprivozn@redhat.com, eblake@redhat.com,
	mdroth@linux.vnet.ibm.com, jcody@redhat.com
Subject: [Qemu-devel] [PATCH 1/4] qemu-ga: set O_NONBLOCK for serial channels
Date: Tue, 31 Jan 2012 17:53:28 -0200	[thread overview]
Message-ID: <1328039611-24048-2-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1328039611-24048-1-git-send-email-lcapitulino@redhat.com>

This fixes a bug when using -m isa-serial where qemu-ga will
hang on a read()'s when communicating to the host via isa-serial.

Original fix by Michael Roth.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 qemu-ga.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qemu-ga.c b/qemu-ga.c
index 29e4f64..647df82 100644
--- a/qemu-ga.c
+++ b/qemu-ga.c
@@ -504,7 +504,7 @@ static void init_guest_agent(GAState *s)
             exit(EXIT_FAILURE);
         }
     } else if (strcmp(s->method, "isa-serial") == 0) {
-        fd = qemu_open(s->path, O_RDWR | O_NOCTTY);
+        fd = qemu_open(s->path, O_RDWR | O_NOCTTY | O_NONBLOCK);
         if (fd == -1) {
             g_critical("error opening channel: %s", strerror(errno));
             exit(EXIT_FAILURE);
-- 
1.7.9.rc2

  reply	other threads:[~2012-01-31 19:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-31 19:53 [Qemu-devel] [PATCH v8 0/4]: qemu-ga: add guest-suspend commands Luiz Capitulino
2012-01-31 19:53 ` Luiz Capitulino [this message]
2012-01-31 19:53 ` [Qemu-devel] [PATCH 2/4] qemu-ga: add guest-suspend-disk Luiz Capitulino
2012-01-31 19:53 ` [Qemu-devel] [PATCH 3/4] qemu-ga: add guest-suspend-ram Luiz Capitulino
2012-01-31 19:53 ` [Qemu-devel] [PATCH 4/4] qemu-ga: add guest-suspend-hybrid Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328039611-24048-2-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jcody@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mprivozn@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).