From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rsznu-0005o8-0K for qemu-devel@nongnu.org; Thu, 02 Feb 2012 11:46:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rsznp-0002cm-LR for qemu-devel@nongnu.org; Thu, 02 Feb 2012 11:46:30 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:42927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rsznp-0002Zb-Gg for qemu-devel@nongnu.org; Thu, 02 Feb 2012 11:46:29 -0500 Received: by mail-pw0-f45.google.com with SMTP id a11so2778423pba.4 for ; Thu, 02 Feb 2012 08:46:29 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 2 Feb 2012 17:45:39 +0100 Message-Id: <1328201142-26145-14-git-send-email-pbonzini@redhat.com> In-Reply-To: <1328201142-26145-1-git-send-email-pbonzini@redhat.com> References: <1328201142-26145-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 13/16] qdev: fix off-by-one List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Integer properties did not work. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 7efcc78..30abae2 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -151,7 +151,7 @@ static void set_int8(Object *obj, Visitor *v, void *opaque, error_propagate(errp, local_err); return; } - if (value > prop->info->min && value <= prop->info->max) { + if (value >= prop->info->min && value <= prop->info->max) { *ptr = value; } else { error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE, @@ -259,7 +259,7 @@ static void set_int16(Object *obj, Visitor *v, void *opaque, error_propagate(errp, local_err); return; } - if (value > prop->info->min && value <= prop->info->max) { + if (value >= prop->info->min && value <= prop->info->max) { *ptr = value; } else { error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE, @@ -333,7 +333,7 @@ static void set_int32(Object *obj, Visitor *v, void *opaque, error_propagate(errp, local_err); return; } - if (value > prop->info->min && value <= prop->info->max) { + if (value >= prop->info->min && value <= prop->info->max) { *ptr = value; } else { error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE, -- 1.7.7.6