From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug
Date: Thu, 2 Feb 2012 17:45:27 +0100 [thread overview]
Message-ID: <1328201142-26145-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1328201142-26145-1-git-send-email-pbonzini@redhat.com>
The reference that is returned by qdev_device_add is never given
back, so that device_del does not cause the refcount to go to zero
(and thus does nothing).
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
vl.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index d88a18c..c63af69 100644
--- a/vl.c
+++ b/vl.c
@@ -1746,6 +1746,7 @@ static int device_init_func(QemuOpts *opts, void *opaque)
dev = qdev_device_add(opts);
if (!dev)
return -1;
+ object_unref(OBJECT(dev));
return 0;
}
--
1.7.7.6
next prev parent reply other threads:[~2012-02-02 16:46 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 16:45 [Qemu-devel] [PATCH 00/16] access qdev properties via QOM Paolo Bonzini
2012-02-02 16:45 ` Paolo Bonzini [this message]
2012-02-02 17:03 ` [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug Anthony Liguori
2012-02-02 17:29 ` Paolo Bonzini
2012-02-02 19:01 ` Anthony Liguori
2012-02-02 19:07 ` Alexander Graf
2012-02-02 20:03 ` Anthony Liguori
2012-02-02 20:31 ` Alexander Graf
2012-02-03 16:37 ` Anthony Liguori
2012-02-03 16:57 ` Alexander Graf
2012-02-03 17:12 ` Anthony Liguori
2012-02-03 14:27 ` Anthony Liguori
2012-02-04 0:27 ` Paolo Bonzini
2012-02-04 3:03 ` Anthony Liguori
2012-02-04 6:51 ` Paolo Bonzini
2012-02-04 17:13 ` Anthony Liguori
2012-02-02 16:45 ` [Qemu-devel] [PATCH 02/16] qom: store object with correct type in interface links Paolo Bonzini
2012-02-02 17:05 ` Anthony Liguori
2012-02-03 12:10 ` Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 03/16] qom: do not include qdev header file Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers Paolo Bonzini
2012-02-02 19:06 ` Anthony Liguori
2012-02-02 19:21 ` Andreas Färber
2012-02-02 20:58 ` Anthony Liguori
2012-02-02 19:24 ` Paolo Bonzini
2012-02-02 19:29 ` Paolo Bonzini
2012-02-02 20:01 ` Anthony Liguori
2012-02-02 19:36 ` Anthony Liguori
2012-02-02 20:08 ` Paolo Bonzini
2012-02-02 20:59 ` Anthony Liguori
2012-02-02 16:45 ` [Qemu-devel] [PATCH 05/16] qom: add property get/set wrappers for C types Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 06/16] qdev: remove direct calls to print/parse Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 07/16] qdev: allow reusing get/set for legacy property Paolo Bonzini
2012-02-02 22:38 ` Andreas Färber
2012-02-03 8:11 ` Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 08/16] qdev: remove parse method for string properties Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 09/16] qdev: remove parse/print methods for mac properties Paolo Bonzini
2012-02-02 20:05 ` Anthony Liguori
2012-02-02 16:45 ` [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer Paolo Bonzini
2012-02-02 20:07 ` Anthony Liguori
2012-02-02 20:19 ` Paolo Bonzini
2012-02-03 14:14 ` Anthony Liguori
2012-02-04 0:21 ` Paolo Bonzini
2012-02-04 0:43 ` Paolo Bonzini
2012-02-04 3:00 ` Anthony Liguori
2012-02-04 6:42 ` Paolo Bonzini
2012-02-04 7:13 ` Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 11/16] qdev: remove parse/print methods for pointer properties Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 12/16] qdev: let QOM free properties Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 13/16] qdev: fix off-by-one Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 14/16] qdev: access properties via QOM Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 15/16] qdev: inline qdev_prop_set into qdev_prop_set_ptr Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 16/16] qdev: initialize properties via QOM Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328201142-26145-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).