From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rtaam-000265-LC for qemu-devel@nongnu.org; Sat, 04 Feb 2012 03:03:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rtaah-0005IN-1v for qemu-devel@nongnu.org; Sat, 04 Feb 2012 03:03:26 -0500 Received: from mail-wi0-f173.google.com ([209.85.212.173]:54242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rtaag-0005ED-2T for qemu-devel@nongnu.org; Sat, 04 Feb 2012 03:03:22 -0500 Received: by mail-wi0-f173.google.com with SMTP id hi20so3684797wib.4 for ; Sat, 04 Feb 2012 00:03:21 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Sat, 4 Feb 2012 09:02:51 +0100 Message-Id: <1328342577-25732-22-git-send-email-pbonzini@redhat.com> In-Reply-To: <1328342577-25732-1-git-send-email-pbonzini@redhat.com> References: <1328342577-25732-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v2 21/27] qdev: fix off-by-one List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Integer properties did not work. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index d69a987..debb37f 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -151,7 +151,7 @@ static void set_int8(Object *obj, Visitor *v, void *opaque, error_propagate(errp, local_err); return; } - if (value > prop->info->min && value <= prop->info->max) { + if (value >= prop->info->min && value <= prop->info->max) { *ptr = value; } else { error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE, @@ -259,7 +259,7 @@ static void set_int16(Object *obj, Visitor *v, void *opaque, error_propagate(errp, local_err); return; } - if (value > prop->info->min && value <= prop->info->max) { + if (value >= prop->info->min && value <= prop->info->max) { *ptr = value; } else { error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE, @@ -333,7 +333,7 @@ static void set_int32(Object *obj, Visitor *v, void *opaque, error_propagate(errp, local_err); return; } - if (value > prop->info->min && value <= prop->info->max) { + if (value >= prop->info->min && value <= prop->info->max) { *ptr = value; } else { error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE, -- 1.7.7.6