From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH 13/19] qemu-char: Chardev open error reporting, parport part
Date: Tue, 7 Feb 2012 15:09:20 +0100 [thread overview]
Message-ID: <1328623766-12287-14-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1328623766-12287-1-git-send-email-armbru@redhat.com>
Unlike many other backends, these leave open error reporting to their
caller. Because the caller doesn't know what went wrong, this results
in a pretty useless error message.
Change them to report their errors themselves. Improves user-hostile
messages like this one for "-chardev tty,id=foo,path=/dev/parport0"
chardev: opening backend "parport" failed
to
qemu-system-x86_64: -chardev parport,id=foo,path=/dev/parport0: Can't open '/dev/parport0': Permission denied
chardev: opening backend "parport" failed
The useless "opening backend failed" message will be cleaned up
shortly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qemu-char.c | 21 ++++++++++++++++++---
1 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 1ff7f4b..ecbb595 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1371,14 +1371,18 @@ static CharDriverState *qemu_chr_open_pp(QemuOpts *opts)
ParallelCharDriver *drv;
int fd;
+ if (!filename) {
+ error_report("parport character device requires parameter path");
+ return NULL;
+ }
+
TFR(fd = qemu_open(filename, O_RDWR));
if (fd < 0) {
- return NULL;
+ goto err;
}
if (ioctl(fd, PPCLAIM) < 0) {
- close(fd);
- return NULL;
+ goto err;
}
drv = g_malloc0(sizeof(ParallelCharDriver));
@@ -1394,6 +1398,11 @@ static CharDriverState *qemu_chr_open_pp(QemuOpts *opts)
qemu_chr_generic_open(chr);
return chr;
+
+err:
+ error_report("Can't open '%s': %s", filename, strerror(errno));
+ close(fd);
+ return NULL;
}
#endif /* __linux__ */
@@ -1441,8 +1450,14 @@ static CharDriverState *qemu_chr_open_pp(QemuOpts *opts)
CharDriverState *chr;
int fd;
+ if (!filename) {
+ error_report("parport character device requires parameter path");
+ return NULL;
+ }
+
fd = qemu_open(filename, O_RDWR);
if (fd < 0) {
+ error_report("Can't open '%s': %s", filename, strerror(errno));
return NULL;
}
--
1.7.6.5
next prev parent reply other threads:[~2012-02-07 14:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 14:09 [Qemu-devel] [PATCH 00/19] Fix and improve chardev open error messages Markus Armbruster
2012-02-07 14:09 ` [Qemu-devel] [PATCH 01/19] Revert "qemu-char: Print strerror message on failure" and deps Markus Armbruster
2012-02-07 15:06 ` Anthony Liguori
2012-02-07 14:09 ` [Qemu-devel] [PATCH 02/19] qemu-char: Use qemu_open() to avoid leaking fds to children Markus Armbruster
2012-02-07 15:07 ` Anthony Liguori
2012-02-07 14:09 ` [Qemu-devel] [PATCH 03/19] qemu-char: Re-apply style fixes from just reverted aad04cd0 Markus Armbruster
2012-02-07 15:07 ` Anthony Liguori
2012-02-07 14:09 ` [Qemu-devel] [PATCH 04/19] qemu-char: qemu_chr_open_fd() can't fail, don't check Markus Armbruster
2012-02-07 15:24 ` Anthony Liguori
2012-02-07 14:09 ` [Qemu-devel] [PATCH 05/19] vl.c: Error locations for options using add_device_config() Markus Armbruster
2012-02-07 14:09 ` [Qemu-devel] [PATCH 06/19] gdbstub: Error locations for -gdb Markus Armbruster
2012-02-07 15:32 ` Kevin Wolf
2012-02-09 15:08 ` Markus Armbruster
2012-02-07 14:09 ` [Qemu-devel] [PATCH 07/19] sockets: Drop sockets_debug debug code Markus Armbruster
2012-02-07 14:09 ` [Qemu-devel] [PATCH 08/19] sockets: Clean up inet_listen_opts()'s convoluted bind() loop Markus Armbruster
2012-02-07 14:09 ` [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part Markus Armbruster
2012-02-07 15:13 ` Anthony Liguori
2012-02-09 16:05 ` Markus Armbruster
2012-02-14 17:24 ` Markus Armbruster
2012-02-14 19:05 ` Anthony Liguori
2012-02-15 13:33 ` Markus Armbruster
2012-02-22 20:28 ` Anthony Liguori
2012-02-23 8:15 ` Markus Armbruster
2012-08-29 15:15 ` Amos Kong
2012-08-29 16:04 ` Amos Kong
2012-09-05 2:19 ` Amos Kong
2012-09-05 18:52 ` Luiz Capitulino
2012-02-07 14:09 ` [Qemu-devel] [PATCH 10/19] qemu-char: Chardev open error reporting, !_WIN32 part Markus Armbruster
2012-02-07 15:52 ` Kevin Wolf
2012-02-09 15:16 ` Markus Armbruster
2012-02-09 15:39 ` Kevin Wolf
2012-02-09 16:19 ` Markus Armbruster
2012-02-09 16:31 ` Luiz Capitulino
2012-02-09 17:08 ` Markus Armbruster
2012-02-07 14:09 ` [Qemu-devel] [PATCH 11/19] qemu-char: Chardev open error reporting, _WIN32 part Markus Armbruster
2012-02-07 14:09 ` [Qemu-devel] [PATCH 12/19] qemu-char: Chardev open error reporting, tty part Markus Armbruster
2012-02-07 14:09 ` Markus Armbruster [this message]
2012-02-07 14:09 ` [Qemu-devel] [PATCH 14/19] console: Eliminate text_consoles[] Markus Armbruster
2012-02-07 14:09 ` [Qemu-devel] [PATCH 15/19] console: Chardev open error reporting, console part Markus Armbruster
2012-02-07 14:09 ` [Qemu-devel] [PATCH 16/19] spice-qemu-char: Chardev open error reporting, spicevmc part Markus Armbruster
2012-02-07 14:09 ` [Qemu-devel] [PATCH 17/19] baum: Chardev open error reporting, braille part Markus Armbruster
2012-02-07 14:09 ` [Qemu-devel] [PATCH 18/19] qemu-char: Chardev open error reporting, generic part Markus Armbruster
2012-02-07 14:09 ` [Qemu-devel] [PATCH 19/19] qemu-char: Fix legacy chardev syntax error reporting Markus Armbruster
2012-02-07 16:05 ` [Qemu-devel] [PATCH 00/19] Fix and improve chardev open error messages Kevin Wolf
2012-02-24 15:30 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328623766-12287-14-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).