From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ruljq-0001Uz-U1 for qemu-devel@nongnu.org; Tue, 07 Feb 2012 09:09:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ruljg-0005gX-9g for qemu-devel@nongnu.org; Tue, 07 Feb 2012 09:09:42 -0500 Received: from oxygen.pond.sub.org ([78.46.104.156]:39186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ruljg-0005eS-4E for qemu-devel@nongnu.org; Tue, 07 Feb 2012 09:09:32 -0500 From: Markus Armbruster Date: Tue, 7 Feb 2012 15:09:22 +0100 Message-Id: <1328623766-12287-16-git-send-email-armbru@redhat.com> In-Reply-To: <1328623766-12287-1-git-send-email-armbru@redhat.com> References: <1328623766-12287-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 15/19] console: Chardev open error reporting, console part List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, aliguori@us.ibm.com Unlike many other backends, this one leaves open error reporting to its caller. Because the caller doesn't know what went wrong, this results in a pretty useless error message. Change it to report its errors. Improves the message you get when attempting to create too many consoles from chardev: opening backend "vc" failed to qemu-system-x86_64: -chardev vc,id=c13: Can't create more than 12 consoles chardev: opening backend "vc" failed The useless "opening backend failed" message will be cleaned up shortly. Signed-off-by: Markus Armbruster --- console.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/console.c b/console.c index 744ef2d..f6b93bd 100644 --- a/console.c +++ b/console.c @@ -1529,8 +1529,8 @@ CharDriverState *text_console_init(QemuOpts *opts) } else { s = new_console(NULL, TEXT_CONSOLE_FIXED_SIZE); } - if (!s) { + error_report("Can't create more than %d consoles", MAX_CONSOLES); g_free(chr); return NULL; } -- 1.7.6.5