From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ruljr-0001V1-Fv for qemu-devel@nongnu.org; Tue, 07 Feb 2012 09:09:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rulje-0005e8-TI for qemu-devel@nongnu.org; Tue, 07 Feb 2012 09:09:43 -0500 Received: from oxygen.pond.sub.org ([78.46.104.156]:39173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rulje-0005dE-N3 for qemu-devel@nongnu.org; Tue, 07 Feb 2012 09:09:30 -0500 From: Markus Armbruster Date: Tue, 7 Feb 2012 15:09:11 +0100 Message-Id: <1328623766-12287-5-git-send-email-armbru@redhat.com> In-Reply-To: <1328623766-12287-1-git-send-email-armbru@redhat.com> References: <1328623766-12287-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 04/19] qemu-char: qemu_chr_open_fd() can't fail, don't check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, aliguori@us.ibm.com Cleaned up silently in commit aad04cd0, but that just got reverted. Re-apply this part. Signed-off-by: Markus Armbruster --- qemu-char.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index c25863a..bb9e3f5 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1226,10 +1226,6 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) } tty_serial_init(fd, 115200, 'N', 8, 1); chr = qemu_chr_open_fd(fd, fd); - if (!chr) { - close(fd); - return NULL; - } chr->chr_ioctl = tty_serial_ioctl; chr->chr_close = qemu_chr_close_tty; return chr; -- 1.7.6.5