From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv9Rf-00013w-FC for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:28:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rv9RV-00007H-3j for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:28:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv9RU-00006d-KE for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:28:20 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q18FSJGc019731 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 8 Feb 2012 10:28:20 -0500 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q18FSHVK030293 for ; Wed, 8 Feb 2012 10:28:19 -0500 From: Avi Kivity Date: Wed, 8 Feb 2012 17:27:57 +0200 Message-Id: <1328714879-18906-9-git-send-email-avi@redhat.com> In-Reply-To: <1328714879-18906-1-git-send-email-avi@redhat.com> References: <1328714879-18906-1-git-send-email-avi@redhat.com> Subject: [Qemu-devel] [PATCH 08/10] memory: don't pass ->readable attribute to cpu_register_physical_memory_log List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org It can be derived from the MemoryRegion itself (which is why it is not used there). Signed-off-by: Avi Kivity --- exec-obsolete.h | 2 +- exec.c | 2 +- memory.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/exec-obsolete.h b/exec-obsolete.h index 94c23d0..23ffbaa 100644 --- a/exec-obsolete.h +++ b/exec-obsolete.h @@ -37,7 +37,7 @@ void cpu_unregister_io_memory(int table_address); struct MemoryRegionSection; void cpu_register_physical_memory_log(struct MemoryRegionSection *section, - bool readable, bool readonly); + bool readonly); void qemu_register_coalesced_mmio(target_phys_addr_t addr, ram_addr_t size); void qemu_unregister_coalesced_mmio(target_phys_addr_t addr, ram_addr_t size); diff --git a/exec.c b/exec.c index b81677a..d3020ab 100644 --- a/exec.c +++ b/exec.c @@ -2529,7 +2529,7 @@ static subpage_t *subpage_init (target_phys_addr_t base, ram_addr_t *phys, before calculating this offset. This should not be a problem unless the low bits of start_addr and region_offset differ. */ void cpu_register_physical_memory_log(MemoryRegionSection *section, - bool readable, bool readonly) + bool readonly) { target_phys_addr_t start_addr = section->offset_within_address_space; ram_addr_t size = section->size; diff --git a/memory.c b/memory.c index 4f37152..71039c4 100644 --- a/memory.c +++ b/memory.c @@ -346,7 +346,7 @@ static void as_memory_range_add(AddressSpace *as, FlatRange *fr) .readonly = fr->readonly, }; - cpu_register_physical_memory_log(§ion, fr->readable, fr->readonly); + cpu_register_physical_memory_log(§ion, fr->readonly); } static void as_memory_range_del(AddressSpace *as, FlatRange *fr) @@ -359,7 +359,7 @@ static void as_memory_range_del(AddressSpace *as, FlatRange *fr) .readonly = fr->readonly, }; - cpu_register_physical_memory_log(§ion, true, false); + cpu_register_physical_memory_log(§ion, false); } static void as_memory_log_start(AddressSpace *as, FlatRange *fr) -- 1.7.9