qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH 9/9] linux-user: brk() debugging
Date: Fri, 10 Feb 2012 11:34:13 +0000	[thread overview]
Message-ID: <1328873653-10554-10-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1328873653-10554-1-git-send-email-stefanha@linux.vnet.ibm.com>

From: Paul Brook <paul@codesourcery.com>

Fix format type mismatches in do_brk debug printfs.

Signed-off-by: Paul Brook <paul@codesourcery.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 linux-user/syscall.c |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index e868ec6..8a11213 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -756,14 +756,15 @@ abi_long do_brk(abi_ulong new_brk)
     abi_long mapped_addr;
     int	new_alloc_size;
 
-    DEBUGF_BRK("do_brk(%#010x) -> ", new_brk);
+    DEBUGF_BRK("do_brk(" TARGET_ABI_FMT_lx ") -> ", new_brk);
 
     if (!new_brk) {
-        DEBUGF_BRK("%#010x (!new_brk)\n", target_brk);
+        DEBUGF_BRK(TARGET_ABI_FMT_lx " (!new_brk)\n", target_brk);
         return target_brk;
     }
     if (new_brk < target_original_brk) {
-        DEBUGF_BRK("%#010x (new_brk < target_original_brk)\n", target_brk);
+        DEBUGF_BRK(TARGET_ABI_FMT_lx " (new_brk < target_original_brk)\n",
+                   target_brk);
         return target_brk;
     }
 
@@ -776,7 +777,7 @@ abi_long do_brk(abi_ulong new_brk)
             memset(g2h(target_brk), 0, new_brk - target_brk);
         }
 	target_brk = new_brk;
-        DEBUGF_BRK("%#010x (new_brk <= brk_page)\n", target_brk);
+        DEBUGF_BRK(TARGET_ABI_FMT_lx " (new_brk <= brk_page)\n", target_brk);
     	return target_brk;
     }
 
@@ -803,7 +804,8 @@ abi_long do_brk(abi_ulong new_brk)
 
         target_brk = new_brk;
         brk_page = HOST_PAGE_ALIGN(target_brk);
-        DEBUGF_BRK("%#010x (mapped_addr == brk_page)\n", target_brk);
+        DEBUGF_BRK(TARGET_ABI_FMT_lx " (mapped_addr == brk_page)\n",
+            target_brk);
         return target_brk;
     } else if (mapped_addr != -1) {
         /* Mapped but at wrong address, meaning there wasn't actually
@@ -811,10 +813,10 @@ abi_long do_brk(abi_ulong new_brk)
          */
         target_munmap(mapped_addr, new_alloc_size);
         mapped_addr = -1;
-        DEBUGF_BRK("%#010x (mapped_addr != -1)\n", target_brk);
+        DEBUGF_BRK(TARGET_ABI_FMT_lx " (mapped_addr != -1)\n", target_brk);
     }
     else {
-        DEBUGF_BRK("%#010x (otherwise)\n", target_brk);
+        DEBUGF_BRK(TARGET_ABI_FMT_lx " (otherwise)\n", target_brk);
     }
 
 #if defined(TARGET_ALPHA)
-- 
1.7.8.3

  parent reply	other threads:[~2012-02-10 11:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10 11:34 [Qemu-devel] [PULL 0/9] Trivial patches for 28 January to 10 February 2012 Stefan Hajnoczi
2012-02-10 11:34 ` [Qemu-devel] [PATCH 1/9] linux-user: fail execve() if env/args too big Stefan Hajnoczi
2012-02-10 11:34 ` [Qemu-devel] [PATCH 2/9] CODING_STYLE: Clarify style for enum and function type names Stefan Hajnoczi
2012-02-10 11:34 ` [Qemu-devel] [PATCH 3/9] cpu-exec.c: Correct comment about this file and indentation cleanup Stefan Hajnoczi
2012-02-10 11:34 ` [Qemu-devel] [PATCH 4/9] ide: fix compilation errors when DEBUG_IDE is set Stefan Hajnoczi
2012-02-10 11:34 ` [Qemu-devel] [PATCH 5/9] vl.c: Fix typo in variable name Stefan Hajnoczi
2012-02-10 11:34 ` [Qemu-devel] [PATCH 6/9] fmopl: Fix typo in function name Stefan Hajnoczi
2012-02-10 11:34 ` [Qemu-devel] [PATCH 7/9] net: remove extra spaces in help messages Stefan Hajnoczi
2012-02-17  6:34   ` Zhi Yong Wu
2012-02-17  6:53     ` Zhi Yong Wu
2012-02-10 11:34 ` [Qemu-devel] [PATCH 8/9] virtio: Remove unneeded g_free() check in virtio_cleanup() Stefan Hajnoczi
2012-02-10 11:34 ` Stefan Hajnoczi [this message]
2012-02-17 13:53 ` [Qemu-devel] [PULL 0/9] Trivial patches for 28 January to 10 February 2012 Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328873653-10554-10-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).