From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, 陳韋任 <chenwj@iis.sinica.edu.tw>,
"Stefan Hajnoczi" <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 3/9] cpu-exec.c: Correct comment about this file and indentation cleanup
Date: Fri, 10 Feb 2012 11:34:07 +0000 [thread overview]
Message-ID: <1328873653-10554-4-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1328873653-10554-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: 陳韋任 <chenwj@iis.sinica.edu.tw>
Each target uses the #define macro (in target-xxx/cpu.h) to rename
cpu_exec (cpu-exec.c) to cpu_xxx_exec, then defines its own cpu_loop
which calls cpu_xxx_exec. So basically, cpu-exec.c is not only the i386
emulator main execution loop. This patch corrects the comment of this
file and does indentation cleanup.
Signed-off-by: Chen Wei-Ren (陳韋任) <chenwj@iis.sinica.edu.tw>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
cpu-exec.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cpu-exec.c b/cpu-exec.c
index a9fa608..2c2d24e 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -1,5 +1,5 @@
/*
- * i386 emulator main execution loop
+ * emulator main execution loop
*
* Copyright (c) 2003-2005 Fabrice Bellard
*
@@ -304,7 +304,7 @@ int cpu_exec(CPUState *env)
env->hflags2 |= HF2_NMI_MASK;
do_interrupt_x86_hardirq(env, EXCP02_NMI, 1);
next_tb = 0;
- } else if (interrupt_request & CPU_INTERRUPT_MCE) {
+ } else if (interrupt_request & CPU_INTERRUPT_MCE) {
env->interrupt_request &= ~CPU_INTERRUPT_MCE;
do_interrupt_x86_hardirq(env, EXCP12_MCHK, 0);
next_tb = 0;
@@ -390,7 +390,7 @@ int cpu_exec(CPUState *env)
next_tb = 0;
}
}
- }
+ }
#elif defined(TARGET_ARM)
if (interrupt_request & CPU_INTERRUPT_FIQ
&& !(env->uncached_cpsr & CPSR_F)) {
@@ -429,7 +429,7 @@ int cpu_exec(CPUState *env)
{
int idx = -1;
/* ??? This hard-codes the OSF/1 interrupt levels. */
- switch (env->pal_mode ? 7 : env->ps & PS_INT_MASK) {
+ switch (env->pal_mode ? 7 : env->ps & PS_INT_MASK) {
case 0 ... 3:
if (interrupt_request & CPU_INTERRUPT_HARD) {
idx = EXCP_DEV_INTERRUPT;
@@ -562,7 +562,7 @@ int cpu_exec(CPUState *env)
barrier();
if (likely(!env->exit_request)) {
tc_ptr = tb->tc_ptr;
- /* execute the generated code */
+ /* execute the generated code */
next_tb = tcg_qemu_tb_exec(env, tc_ptr);
if ((next_tb & 3) == 2) {
/* Instruction counter expired. */
--
1.7.8.3
next prev parent reply other threads:[~2012-02-10 11:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 11:34 [Qemu-devel] [PULL 0/9] Trivial patches for 28 January to 10 February 2012 Stefan Hajnoczi
2012-02-10 11:34 ` [Qemu-devel] [PATCH 1/9] linux-user: fail execve() if env/args too big Stefan Hajnoczi
2012-02-10 11:34 ` [Qemu-devel] [PATCH 2/9] CODING_STYLE: Clarify style for enum and function type names Stefan Hajnoczi
2012-02-10 11:34 ` Stefan Hajnoczi [this message]
2012-02-10 11:34 ` [Qemu-devel] [PATCH 4/9] ide: fix compilation errors when DEBUG_IDE is set Stefan Hajnoczi
2012-02-10 11:34 ` [Qemu-devel] [PATCH 5/9] vl.c: Fix typo in variable name Stefan Hajnoczi
2012-02-10 11:34 ` [Qemu-devel] [PATCH 6/9] fmopl: Fix typo in function name Stefan Hajnoczi
2012-02-10 11:34 ` [Qemu-devel] [PATCH 7/9] net: remove extra spaces in help messages Stefan Hajnoczi
2012-02-17 6:34 ` Zhi Yong Wu
2012-02-17 6:53 ` Zhi Yong Wu
2012-02-10 11:34 ` [Qemu-devel] [PATCH 8/9] virtio: Remove unneeded g_free() check in virtio_cleanup() Stefan Hajnoczi
2012-02-10 11:34 ` [Qemu-devel] [PATCH 9/9] linux-user: brk() debugging Stefan Hajnoczi
2012-02-17 13:53 ` [Qemu-devel] [PULL 0/9] Trivial patches for 28 January to 10 February 2012 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328873653-10554-4-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=chenwj@iis.sinica.edu.tw \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).