From: Anthony PERARD <anthony.perard@citrix.com>
To: QEMU-devel <qemu-devel@nongnu.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Xen Devel <xen-devel@lists.xensource.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [Qemu-devel] [PATCH V6 11/11] pci: Do not check if a bus exist in pci_parse_devaddr.
Date: Mon, 13 Feb 2012 12:20:13 +0000 [thread overview]
Message-ID: <1329135613-26061-12-git-send-email-anthony.perard@citrix.com> (raw)
In-Reply-To: <1329135613-26061-1-git-send-email-anthony.perard@citrix.com>
Actually, pci_parse_devaddr checks if the dom/bus of the PCI address exist. But
this should be the jobs of a caller. In fact, the two callers of this function
will try to retrieve the PCIBus related to the devaddr and return an error if
they cannot.
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
hw/pci.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index ebb5de9..da7cf79 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -529,10 +529,6 @@ int pci_parse_devaddr(const char *addr, int *domp, int *busp,
if (*e)
return -1;
- /* Note: QEMU doesn't implement domains other than 0 */
- if (!pci_find_bus(pci_find_root_bus(dom), bus))
- return -1;
-
*domp = dom;
*busp = bus;
*slotp = slot;
--
Anthony PERARD
next prev parent reply other threads:[~2012-02-13 12:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 12:20 [Qemu-devel] [PATCH V6 00/11] Xen PCI Passthrough Anthony PERARD
2012-02-13 12:20 ` [Qemu-devel] [PATCH V6 01/11] pci_ids: Add INTEL_82599_VF id Anthony PERARD
2012-02-13 12:20 ` [Qemu-devel] [PATCH V6 02/11] pci_regs: Fix value of PCI_EXP_TYPE_RC_EC Anthony PERARD
2012-02-13 12:20 ` [Qemu-devel] [PATCH V6 03/11] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE Anthony PERARD
2012-02-13 12:20 ` [Qemu-devel] [PATCH V6 04/11] configure: Introduce --enable-xen-pci-passthrough Anthony PERARD
2012-02-13 12:20 ` [Qemu-devel] [PATCH V6 05/11] Introduce HostPCIDevice to access a pci device on the host Anthony PERARD
2012-02-13 12:20 ` [Qemu-devel] [PATCH V6 06/11] pci.c: Add pci_check_bar_overlap Anthony PERARD
2012-02-13 12:20 ` [Qemu-devel] [PATCH V6 07/11] Introduce Xen PCI Passthrough, qdevice (1/3) Anthony PERARD
2012-02-13 12:20 ` [Qemu-devel] [PATCH V6 08/11] Introduce Xen PCI Passthrough, PCI config space helpers (2/3) Anthony PERARD
2012-02-13 12:20 ` [Qemu-devel] [PATCH V6 09/11] Introduce apic-msidef.h Anthony PERARD
2012-02-13 12:20 ` [Qemu-devel] [PATCH V6 10/11] Introduce Xen PCI Passthrough, MSI (3/3) Anthony PERARD
2012-02-14 13:13 ` [Qemu-devel] [Xen-devel] " Jan Beulich
2012-02-14 13:46 ` Anthony PERARD
2012-02-14 14:00 ` Jan Beulich
2012-02-13 12:20 ` Anthony PERARD [this message]
2012-02-13 12:53 ` [Qemu-devel] [PATCH V6 11/11] pci: Do not check if a bus exist in pci_parse_devaddr Michael S. Tsirkin
2012-02-13 15:24 ` Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329135613-26061-12-git-send-email-anthony.perard@citrix.com \
--to=anthony.perard@citrix.com \
--cc=aliguori@us.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).